Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully remove DuckDuckGo email service. #2919

Merged
merged 1 commit into from
Nov 27, 2022

Conversation

BlackDex
Copy link
Collaborator

The DuckDuckGo email service is not supported for self-hosted servers. This option is already hidden via the latest web-vault.

This PR also removes some server side headers.

Fixes #2828

The DuckDuckGo email service is not supported for self-hosted servers.
This option is already hidden via the latest web-vault.

This PR also removes some server side headers.

Fixes dani-garcia#2828
@dani-garcia dani-garcia merged commit aa8d050 into dani-garcia:main Nov 27, 2022
@BlackDex BlackDex deleted the issue-2828 branch November 27, 2022 22:32
@t3dium
Copy link

t3dium commented Dec 24, 2022

this'll still work fine in the local clients right? since i haven't experienced any issues using duckduckgo's email forwarding within the clients, so im hesitant to update vaultwarden

@BlackDex
Copy link
Collaborator Author

It's all client side. But not supported by the web-vault though.
Nothing server side.

@ItsDrike
Copy link

Just curious here, why was duckduckgo removed from the web vault here? The linked issue this PR is supposed to be fixing seems to have been deleted, and I've only noticed this message in the release logs, would you mind explaining why this was done?

@stefan0xC
Copy link
Contributor

stefan0xC commented Jan 29, 2023

Seems like the user who reported the issue initially has deleted their GitHub profile taking the initial issue with them.

On self-hosted servers it does not work because it is CORS protected. @BlackDex reported the issue upstream bitwarden/clients#3798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants