-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update settings description #2928
Conversation
src/config.rs
Outdated
@@ -545,7 +545,7 @@ make_config! { | |||
|
|||
/// Seconds between admin requests |> Number of seconds, on average, between admin requests from the same IP address before rate limiting kicks in | |||
admin_ratelimit_seconds: u64, false, def, 300; | |||
/// Max burst size for login requests |> Allow a burst of requests of up to this size, while maintaining the average indicated by `admin_ratelimit_seconds` | |||
/// Max burst size for admin requests |> Allow a burst of requests of up to this size, while maintaining the average indicated by `admin_ratelimit_seconds` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then, it actually should be admin login
instead. Because now it implies on all admin requests, which is not the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, it should not be change or change to admin login requests
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the latter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this probably needs to be changed in the template:
Line 305 in 7a76731
## Number of seconds, on average, between admin requests from the same IP address before rate limiting kicks in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update it at the same time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this probably needs to be changed in the template:
Line 305 in 7a76731
## Number of seconds, on average, between admin requests from the same IP address before rate limiting kicks in.
This doesn't seem to need an update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not? It says admin
, and not admin login
. Would be best to keep both items consistent not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I will update it later.
Update description to `admin login requests`.
Update description from
login
toadmin
in admin page.Read-Only Config