-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanups and Fixes for Emergency Access #2936
Cleanups and Fixes for Emergency Access #2936
Conversation
18a5346
to
e885064
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the other cron jobs as well and all of them are wrong.
Cron format:
* * * * * Command_to_execute
| | | | |
| | | | Day of the Week ( 0 - 6 ) ( Sunday = 0 )
| | | |
| | | Month ( 1 - 12 )
| | |
| | Day of Month ( 1 - 31 )
| |
| Hour ( 0 - 23 )
|
Min ( 0 - 59 )
According to @stefan0xC, the format is different than the standard cron format.
I'll open a PR to add this info to the template file. This is certainly not clear by just looking at the file....
Update: Scratch that too. It is in the .env.template
file. Strange that I missed this.
- Several cleanups and code optimizations for Emergency Access - Fixed a race-condition regarding jobs for Emergency Access - Some other small changes like `allow(clippy::)` removals Fixes dani-garcia#2925
e885064
to
4aa6dd2
Compare
That was in one of my updates, so it could be you didn't see a recent version. The seconds option is btw a nice addition, at least for me during testing, instead of having to wait a whole minute or 30 seconds hehe. But for that to work, you also need to change the |
Yep, this is possible, because I remember I read the entire template file a while back and that part was new to me.
Good idea. It definitely helps.
Yep, I totally agree. Personally I would have just added new fields at the end, so that it is still compatible with the original format. But I also understand why the dev of the library wanted to have the seconds next to the minutes... |
allow(clippy::)
removalsFixes #2925
Fixes #2955