Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable groups by default and Some optimizations #2995

Merged
merged 1 commit into from
Dec 18, 2022

Conversation

BlackDex
Copy link
Collaborator

  • Put groups support behind a feature flag, and disabled by default. The reason is that it has some known issues, but we want to keep optimizing this feature. Putting it behind a feature flag could help some users, and the developers into optimizing this feature without to much trouble.

Further:

  • Updated jquery to v3.6.2
  • Moved jdenticon.js to load at the bottom, fixes an issue on chromium
  • Added autocomplete attribute to admin login password field
  • Added some extra CSP options (Tested this on Safari, Firefox, Chrome, Bitwarden Desktop)
  • Moved uppercase convertion from runtime to compile-time using paste for building the environment variables, lowers heap allocations.

- Put groups support behind a feature flag, and disabled by default.
  The reason is that it has some known issues, but we want to keep
  optimizing this feature. Putting it behind a feature flag could help
  some users, and the developers into optimizing this feature without to
  much trouble.

Further:

- Updates Rust to v1.66.0
- Updated GHA workflows
- Updated Alpine to 3.17
- Updated jquery to v3.6.2
- Moved jdenticon.js to load at the bottom, fixes an issue on chromium
- Added autocomplete attribute to admin login password field
- Added some extra CSP options (Tested this on Safari, Firefox, Chrome, Bitwarden Desktop)
- Moved uppercase convertion from runtime to compile-time using `paste`
  for building the environment variables, lowers heap allocations.
@dani-garcia dani-garcia merged commit 8b6dfe4 into dani-garcia:main Dec 18, 2022
@BlackDex BlackDex deleted the some-optimizations branch December 18, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants