Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing large note imports #3087

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Fix failing large note imports #3087

merged 1 commit into from
Jan 9, 2023

Commits on Jan 9, 2023

  1. Fix failing large note imports 

    When importing to Vaultwarden (or Bitwarden) notes larger then 10_000
encrypted characters are invalid. This because it for one isn't
compatible with Bitwarden. And some clients tend to break on very large
notes.

We already added a check for this limit when adding a single cipher, but
this caused issues during import, and could cause a partial imported
vault. Bitwarden does some validations before actually running it
through the import process and generates a special error message which
helps the user indicate which items are invalid during the import.

This PR adds that validation check and returns the same kind of error.
Fixes dani-garcia#3048
    @BlackDex
    BlackDex committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    6be26f0 View commit details
    Browse the repository at this point in the history