inline static rsa keys #3475
Merged
inline static rsa keys #3475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you are right. This also looks a bit better i think. Thx. |
dani-garcia
approved these changes
Apr 24, 2023
I think we did before indeed. Long long time ago. |
arthurgeek
referenced
this pull request
in arthurgeek/vaultwarden-fly-template
Jul 12, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [vaultwarden/server](https://togithub.com/dani-garcia/vaultwarden) | stage | minor | `1.28.1-alpine` -> `1.29.0-alpine` | --- ### Release Notes <details> <summary>dani-garcia/vaultwarden (vaultwarden/server)</summary> ### [`v1.29.0`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.29.0) [Compare Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.28.1...1.29.0) #### Major changes and New Features - WebSocket notifications now work via the default HTTP port. No need for `WEBSOCKET_ENABLED` and a separate port anymore. The proxy examples still need to be updated for this. Support for the old websockets port 3012 will remain for the time being. - Mobile Client push notification support, see [#​3304](https://togithub.com/dani-garcia/vaultwarden/issues/3304) thanks [@​GeekCornerGH](https://togithub.com/GeekCornerGH)! - Web-Vault updated to v2023.5.0 (v2023.5.1 does not add any improvements for us) - The latest Bitwarden Directory Connector can be used now ([v2022.11.0](https://togithub.com/bitwarden/directory-connector/releases/tag/v2022.11.0)) - [Storing passkeys](https://bitwarden.com/passwordless-passkeys) is supported, though the clients are not yet released. So, it might be we need to make some changes once they are released. See: [#​3593](https://togithub.com/dani-garcia/vaultwarden/issues/3593), thanks [@​GeekCornerGH](https://togithub.com/GeekCornerGH)! #### What's Changed - check if reset password policy is enabled by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/3427](https://togithub.com/dani-garcia/vaultwarden/pull/3427) - WebSockets via Rocket's Upgrade connection by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3404](https://togithub.com/dani-garcia/vaultwarden/pull/3404) - Several config and admin interface fixes by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3436](https://togithub.com/dani-garcia/vaultwarden/pull/3436) - Fixed missing footer_text and a few inconsistencies in email templates by [@​kennymc-c](https://togithub.com/kennymc-c) in [https://github.com/dani-garcia/vaultwarden/pull/3439](https://togithub.com/dani-garcia/vaultwarden/pull/3439) - Small update to Rocket WebSockets by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3440](https://togithub.com/dani-garcia/vaultwarden/pull/3440) - inline static rsa keys by [@​vilgotf](https://togithub.com/vilgotf) in [https://github.com/dani-garcia/vaultwarden/pull/3475](https://togithub.com/dani-garcia/vaultwarden/pull/3475) - Update Rust and Crates by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3469](https://togithub.com/dani-garcia/vaultwarden/pull/3469) - Change `String` to `&str` for all Rocket functions and some other fixes by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3491](https://togithub.com/dani-garcia/vaultwarden/pull/3491) - Use Rocket `v0.5` branch to fix endpoints by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3502](https://togithub.com/dani-garcia/vaultwarden/pull/3502) - Use fully qualified image names in Dockerfile by [@​gitouche-sur-osm](https://togithub.com/gitouche-sur-osm) in [https://github.com/dani-garcia/vaultwarden/pull/3505](https://togithub.com/dani-garcia/vaultwarden/pull/3505) - policy data should be `null` not an empty object by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/3513](https://togithub.com/dani-garcia/vaultwarden/pull/3513) - update web-vault to v2023.4.2 by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/3522](https://togithub.com/dani-garcia/vaultwarden/pull/3522) - Sync global_domains.json (Pinterest) by [@​jjlin](https://togithub.com/jjlin) in [https://github.com/dani-garcia/vaultwarden/pull/3532](https://togithub.com/dani-garcia/vaultwarden/pull/3532) - Prevent 401 on main admin page by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3547](https://togithub.com/dani-garcia/vaultwarden/pull/3547) - Update crates and GH Workflow by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3548](https://togithub.com/dani-garcia/vaultwarden/pull/3548) - Fix collection change ws notifications by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3546](https://togithub.com/dani-garcia/vaultwarden/pull/3546) - Update Rust and Crates by [@​tessus](https://togithub.com/tessus) in [https://github.com/dani-garcia/vaultwarden/pull/3563](https://togithub.com/dani-garcia/vaultwarden/pull/3563) - feat: Implement Push Notifications sync by [@​GeekCornerGH](https://togithub.com/GeekCornerGH) in [https://github.com/dani-garcia/vaultwarden/pull/3304](https://togithub.com/dani-garcia/vaultwarden/pull/3304) - Implement the Organization API Key support for the new Directory Connector v2022 by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3568](https://togithub.com/dani-garcia/vaultwarden/pull/3568) - Add mobile push device filter to non-null push uuid by [@​quexten](https://togithub.com/quexten) in [https://github.com/dani-garcia/vaultwarden/pull/3578](https://togithub.com/dani-garcia/vaultwarden/pull/3578) - Update crates and workflow by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3603](https://togithub.com/dani-garcia/vaultwarden/pull/3603) - Add group import on invite by [@​farodin91](https://togithub.com/farodin91) in [https://github.com/dani-garcia/vaultwarden/pull/3606](https://togithub.com/dani-garcia/vaultwarden/pull/3606) - Fix send access regression by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3608](https://togithub.com/dani-garcia/vaultwarden/pull/3608) - feat: Support for storing passkeys in the vault by [@​GeekCornerGH](https://togithub.com/GeekCornerGH) in [https://github.com/dani-garcia/vaultwarden/pull/3593](https://togithub.com/dani-garcia/vaultwarden/pull/3593) - add user to collection during creation by [@​farodin91](https://togithub.com/farodin91) in [https://github.com/dani-garcia/vaultwarden/pull/3609](https://togithub.com/dani-garcia/vaultwarden/pull/3609) - Updated docker run command by [@​DenuxPlays](https://togithub.com/DenuxPlays) in [https://github.com/dani-garcia/vaultwarden/pull/3620](https://togithub.com/dani-garcia/vaultwarden/pull/3620) - Added-External_id for Collections by [@​fashberg](https://togithub.com/fashberg) in [https://github.com/dani-garcia/vaultwarden/pull/3623](https://togithub.com/dani-garcia/vaultwarden/pull/3623) - fix missing password check while manual reset password enrollment by [@​sirux88](https://togithub.com/sirux88) in [https://github.com/dani-garcia/vaultwarden/pull/3632](https://togithub.com/dani-garcia/vaultwarden/pull/3632) - Update crates and small clippy fix by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3649](https://togithub.com/dani-garcia/vaultwarden/pull/3649) - fix version when compiled at a specific commit by [@​tessus](https://togithub.com/tessus) in [https://github.com/dani-garcia/vaultwarden/pull/3651](https://togithub.com/dani-garcia/vaultwarden/pull/3651) - Fix org creation regresion by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3659](https://togithub.com/dani-garcia/vaultwarden/pull/3659) #### New Contributors - [@​kennymc-c](https://togithub.com/kennymc-c) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/3439](https://togithub.com/dani-garcia/vaultwarden/pull/3439) - [@​vilgotf](https://togithub.com/vilgotf) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/3475](https://togithub.com/dani-garcia/vaultwarden/pull/3475) - [@​gitouche-sur-osm](https://togithub.com/gitouche-sur-osm) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/3505](https://togithub.com/dani-garcia/vaultwarden/pull/3505) - [@​quexten](https://togithub.com/quexten) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/3578](https://togithub.com/dani-garcia/vaultwarden/pull/3578) - [@​DenuxPlays](https://togithub.com/DenuxPlays) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/3620](https://togithub.com/dani-garcia/vaultwarden/pull/3620) - [@​fashberg](https://togithub.com/fashberg) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/3623](https://togithub.com/dani-garcia/vaultwarden/pull/3623) **Full Changelog**: dani-garcia/vaultwarden@1.28.1...1.29.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/arthurgeek/vaultwarden-fly-template). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41LjMiLCJ1cGRhdGVkSW5WZXIiOiIzNi41LjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
arthurgeek
referenced
this pull request
in arthurgeek/vaultwarden-fly
Jul 12, 2023
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [vaultwarden/server](https://togithub.com/dani-garcia/vaultwarden) | stage | minor | `1.28.1-alpine` -> `1.29.0-alpine` | --- ### Release Notes <details> <summary>dani-garcia/vaultwarden (vaultwarden/server)</summary> ### [`v1.29.0`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.29.0) [Compare Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.28.1...1.29.0) #### Major changes and New Features - WebSocket notifications now work via the default HTTP port. No need for `WEBSOCKET_ENABLED` and a separate port anymore. The proxy examples still need to be updated for this. Support for the old websockets port 3012 will remain for the time being. - Mobile Client push notification support, see [#​3304](https://togithub.com/dani-garcia/vaultwarden/issues/3304) thanks [@​GeekCornerGH](https://togithub.com/GeekCornerGH)! - Web-Vault updated to v2023.5.0 (v2023.5.1 does not add any improvements for us) - The latest Bitwarden Directory Connector can be used now ([v2022.11.0](https://togithub.com/bitwarden/directory-connector/releases/tag/v2022.11.0)) - [Storing passkeys](https://bitwarden.com/passwordless-passkeys) is supported, though the clients are not yet released. So, it might be we need to make some changes once they are released. See: [#​3593](https://togithub.com/dani-garcia/vaultwarden/issues/3593), thanks [@​GeekCornerGH](https://togithub.com/GeekCornerGH)! #### What's Changed - check if reset password policy is enabled by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/3427](https://togithub.com/dani-garcia/vaultwarden/pull/3427) - WebSockets via Rocket's Upgrade connection by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3404](https://togithub.com/dani-garcia/vaultwarden/pull/3404) - Several config and admin interface fixes by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3436](https://togithub.com/dani-garcia/vaultwarden/pull/3436) - Fixed missing footer_text and a few inconsistencies in email templates by [@​kennymc-c](https://togithub.com/kennymc-c) in [https://github.com/dani-garcia/vaultwarden/pull/3439](https://togithub.com/dani-garcia/vaultwarden/pull/3439) - Small update to Rocket WebSockets by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3440](https://togithub.com/dani-garcia/vaultwarden/pull/3440) - inline static rsa keys by [@​vilgotf](https://togithub.com/vilgotf) in [https://github.com/dani-garcia/vaultwarden/pull/3475](https://togithub.com/dani-garcia/vaultwarden/pull/3475) - Update Rust and Crates by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3469](https://togithub.com/dani-garcia/vaultwarden/pull/3469) - Change `String` to `&str` for all Rocket functions and some other fixes by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3491](https://togithub.com/dani-garcia/vaultwarden/pull/3491) - Use Rocket `v0.5` branch to fix endpoints by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3502](https://togithub.com/dani-garcia/vaultwarden/pull/3502) - Use fully qualified image names in Dockerfile by [@​gitouche-sur-osm](https://togithub.com/gitouche-sur-osm) in [https://github.com/dani-garcia/vaultwarden/pull/3505](https://togithub.com/dani-garcia/vaultwarden/pull/3505) - policy data should be `null` not an empty object by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/3513](https://togithub.com/dani-garcia/vaultwarden/pull/3513) - update web-vault to v2023.4.2 by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/3522](https://togithub.com/dani-garcia/vaultwarden/pull/3522) - Sync global_domains.json (Pinterest) by [@​jjlin](https://togithub.com/jjlin) in [https://github.com/dani-garcia/vaultwarden/pull/3532](https://togithub.com/dani-garcia/vaultwarden/pull/3532) - Prevent 401 on main admin page by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3547](https://togithub.com/dani-garcia/vaultwarden/pull/3547) - Update crates and GH Workflow by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3548](https://togithub.com/dani-garcia/vaultwarden/pull/3548) - Fix collection change ws notifications by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3546](https://togithub.com/dani-garcia/vaultwarden/pull/3546) - Update Rust and Crates by [@​tessus](https://togithub.com/tessus) in [https://github.com/dani-garcia/vaultwarden/pull/3563](https://togithub.com/dani-garcia/vaultwarden/pull/3563) - feat: Implement Push Notifications sync by [@​GeekCornerGH](https://togithub.com/GeekCornerGH) in [https://github.com/dani-garcia/vaultwarden/pull/3304](https://togithub.com/dani-garcia/vaultwarden/pull/3304) - Implement the Organization API Key support for the new Directory Connector v2022 by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3568](https://togithub.com/dani-garcia/vaultwarden/pull/3568) - Add mobile push device filter to non-null push uuid by [@​quexten](https://togithub.com/quexten) in [https://github.com/dani-garcia/vaultwarden/pull/3578](https://togithub.com/dani-garcia/vaultwarden/pull/3578) - Update crates and workflow by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3603](https://togithub.com/dani-garcia/vaultwarden/pull/3603) - Add group import on invite by [@​farodin91](https://togithub.com/farodin91) in [https://github.com/dani-garcia/vaultwarden/pull/3606](https://togithub.com/dani-garcia/vaultwarden/pull/3606) - Fix send access regression by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3608](https://togithub.com/dani-garcia/vaultwarden/pull/3608) - feat: Support for storing passkeys in the vault by [@​GeekCornerGH](https://togithub.com/GeekCornerGH) in [https://github.com/dani-garcia/vaultwarden/pull/3593](https://togithub.com/dani-garcia/vaultwarden/pull/3593) - add user to collection during creation by [@​farodin91](https://togithub.com/farodin91) in [https://github.com/dani-garcia/vaultwarden/pull/3609](https://togithub.com/dani-garcia/vaultwarden/pull/3609) - Updated docker run command by [@​DenuxPlays](https://togithub.com/DenuxPlays) in [https://github.com/dani-garcia/vaultwarden/pull/3620](https://togithub.com/dani-garcia/vaultwarden/pull/3620) - Added-External_id for Collections by [@​fashberg](https://togithub.com/fashberg) in [https://github.com/dani-garcia/vaultwarden/pull/3623](https://togithub.com/dani-garcia/vaultwarden/pull/3623) - fix missing password check while manual reset password enrollment by [@​sirux88](https://togithub.com/sirux88) in [https://github.com/dani-garcia/vaultwarden/pull/3632](https://togithub.com/dani-garcia/vaultwarden/pull/3632) - Update crates and small clippy fix by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3649](https://togithub.com/dani-garcia/vaultwarden/pull/3649) - fix version when compiled at a specific commit by [@​tessus](https://togithub.com/tessus) in [https://github.com/dani-garcia/vaultwarden/pull/3651](https://togithub.com/dani-garcia/vaultwarden/pull/3651) - Fix org creation regresion by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3659](https://togithub.com/dani-garcia/vaultwarden/pull/3659) #### New Contributors - [@​kennymc-c](https://togithub.com/kennymc-c) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/3439](https://togithub.com/dani-garcia/vaultwarden/pull/3439) - [@​vilgotf](https://togithub.com/vilgotf) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/3475](https://togithub.com/dani-garcia/vaultwarden/pull/3475) - [@​gitouche-sur-osm](https://togithub.com/gitouche-sur-osm) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/3505](https://togithub.com/dani-garcia/vaultwarden/pull/3505) - [@​quexten](https://togithub.com/quexten) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/3578](https://togithub.com/dani-garcia/vaultwarden/pull/3578) - [@​DenuxPlays](https://togithub.com/DenuxPlays) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/3620](https://togithub.com/dani-garcia/vaultwarden/pull/3620) - [@​fashberg](https://togithub.com/fashberg) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/3623](https://togithub.com/dani-garcia/vaultwarden/pull/3623) **Full Changelog**: dani-garcia/vaultwarden@1.28.1...1.29.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/arthurgeek/vaultwarden-fly-template). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41LjMiLCJ1cGRhdGVkSW5WZXIiOiIzNi41LjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
arthurgeek
referenced
this pull request
in arthurgeek/vaultwarden-fly
Jul 12, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [vaultwarden/server](https://togithub.com/dani-garcia/vaultwarden) | stage | minor | `1.28.1-alpine` -> `1.29.0-alpine` | --- ### Release Notes <details> <summary>dani-garcia/vaultwarden (vaultwarden/server)</summary> ### [`v1.29.0`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.29.0) [Compare Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.28.1...1.29.0) #### Major changes and New Features - WebSocket notifications now work via the default HTTP port. No need for `WEBSOCKET_ENABLED` and a separate port anymore. The proxy examples still need to be updated for this. Support for the old websockets port 3012 will remain for the time being. - Mobile Client push notification support, see [#​3304](https://togithub.com/dani-garcia/vaultwarden/issues/3304) thanks [@​GeekCornerGH](https://togithub.com/GeekCornerGH)! - Web-Vault updated to v2023.5.0 (v2023.5.1 does not add any improvements for us) - The latest Bitwarden Directory Connector can be used now ([v2022.11.0](https://togithub.com/bitwarden/directory-connector/releases/tag/v2022.11.0)) - [Storing passkeys](https://bitwarden.com/passwordless-passkeys) is supported, though the clients are not yet released. So, it might be we need to make some changes once they are released. See: [#​3593](https://togithub.com/dani-garcia/vaultwarden/issues/3593), thanks [@​GeekCornerGH](https://togithub.com/GeekCornerGH)! #### What's Changed - check if reset password policy is enabled by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/3427](https://togithub.com/dani-garcia/vaultwarden/pull/3427) - WebSockets via Rocket's Upgrade connection by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3404](https://togithub.com/dani-garcia/vaultwarden/pull/3404) - Several config and admin interface fixes by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3436](https://togithub.com/dani-garcia/vaultwarden/pull/3436) - Fixed missing footer_text and a few inconsistencies in email templates by [@​kennymc-c](https://togithub.com/kennymc-c) in [https://github.com/dani-garcia/vaultwarden/pull/3439](https://togithub.com/dani-garcia/vaultwarden/pull/3439) - Small update to Rocket WebSockets by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3440](https://togithub.com/dani-garcia/vaultwarden/pull/3440) - inline static rsa keys by [@​vilgotf](https://togithub.com/vilgotf) in [https://github.com/dani-garcia/vaultwarden/pull/3475](https://togithub.com/dani-garcia/vaultwarden/pull/3475) - Update Rust and Crates by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3469](https://togithub.com/dani-garcia/vaultwarden/pull/3469) - Change `String` to `&str` for all Rocket functions and some other fixes by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3491](https://togithub.com/dani-garcia/vaultwarden/pull/3491) - Use Rocket `v0.5` branch to fix endpoints by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3502](https://togithub.com/dani-garcia/vaultwarden/pull/3502) - Use fully qualified image names in Dockerfile by [@​gitouche-sur-osm](https://togithub.com/gitouche-sur-osm) in [https://github.com/dani-garcia/vaultwarden/pull/3505](https://togithub.com/dani-garcia/vaultwarden/pull/3505) - policy data should be `null` not an empty object by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/3513](https://togithub.com/dani-garcia/vaultwarden/pull/3513) - update web-vault to v2023.4.2 by [@​stefan0xC](https://togithub.com/stefan0xC) in [https://github.com/dani-garcia/vaultwarden/pull/3522](https://togithub.com/dani-garcia/vaultwarden/pull/3522) - Sync global_domains.json (Pinterest) by [@​jjlin](https://togithub.com/jjlin) in [https://github.com/dani-garcia/vaultwarden/pull/3532](https://togithub.com/dani-garcia/vaultwarden/pull/3532) - Prevent 401 on main admin page by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3547](https://togithub.com/dani-garcia/vaultwarden/pull/3547) - Update crates and GH Workflow by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3548](https://togithub.com/dani-garcia/vaultwarden/pull/3548) - Fix collection change ws notifications by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3546](https://togithub.com/dani-garcia/vaultwarden/pull/3546) - Update Rust and Crates by [@​tessus](https://togithub.com/tessus) in [https://github.com/dani-garcia/vaultwarden/pull/3563](https://togithub.com/dani-garcia/vaultwarden/pull/3563) - feat: Implement Push Notifications sync by [@​GeekCornerGH](https://togithub.com/GeekCornerGH) in [https://github.com/dani-garcia/vaultwarden/pull/3304](https://togithub.com/dani-garcia/vaultwarden/pull/3304) - Implement the Organization API Key support for the new Directory Connector v2022 by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3568](https://togithub.com/dani-garcia/vaultwarden/pull/3568) - Add mobile push device filter to non-null push uuid by [@​quexten](https://togithub.com/quexten) in [https://github.com/dani-garcia/vaultwarden/pull/3578](https://togithub.com/dani-garcia/vaultwarden/pull/3578) - Update crates and workflow by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3603](https://togithub.com/dani-garcia/vaultwarden/pull/3603) - Add group import on invite by [@​farodin91](https://togithub.com/farodin91) in [https://github.com/dani-garcia/vaultwarden/pull/3606](https://togithub.com/dani-garcia/vaultwarden/pull/3606) - Fix send access regression by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3608](https://togithub.com/dani-garcia/vaultwarden/pull/3608) - feat: Support for storing passkeys in the vault by [@​GeekCornerGH](https://togithub.com/GeekCornerGH) in [https://github.com/dani-garcia/vaultwarden/pull/3593](https://togithub.com/dani-garcia/vaultwarden/pull/3593) - add user to collection during creation by [@​farodin91](https://togithub.com/farodin91) in [https://github.com/dani-garcia/vaultwarden/pull/3609](https://togithub.com/dani-garcia/vaultwarden/pull/3609) - Updated docker run command by [@​DenuxPlays](https://togithub.com/DenuxPlays) in [https://github.com/dani-garcia/vaultwarden/pull/3620](https://togithub.com/dani-garcia/vaultwarden/pull/3620) - Added-External_id for Collections by [@​fashberg](https://togithub.com/fashberg) in [https://github.com/dani-garcia/vaultwarden/pull/3623](https://togithub.com/dani-garcia/vaultwarden/pull/3623) - fix missing password check while manual reset password enrollment by [@​sirux88](https://togithub.com/sirux88) in [https://github.com/dani-garcia/vaultwarden/pull/3632](https://togithub.com/dani-garcia/vaultwarden/pull/3632) - Update crates and small clippy fix by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3649](https://togithub.com/dani-garcia/vaultwarden/pull/3649) - fix version when compiled at a specific commit by [@​tessus](https://togithub.com/tessus) in [https://github.com/dani-garcia/vaultwarden/pull/3651](https://togithub.com/dani-garcia/vaultwarden/pull/3651) - Fix org creation regresion by [@​BlackDex](https://togithub.com/BlackDex) in [https://github.com/dani-garcia/vaultwarden/pull/3659](https://togithub.com/dani-garcia/vaultwarden/pull/3659) #### New Contributors - [@​kennymc-c](https://togithub.com/kennymc-c) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/3439](https://togithub.com/dani-garcia/vaultwarden/pull/3439) - [@​vilgotf](https://togithub.com/vilgotf) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/3475](https://togithub.com/dani-garcia/vaultwarden/pull/3475) - [@​gitouche-sur-osm](https://togithub.com/gitouche-sur-osm) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/3505](https://togithub.com/dani-garcia/vaultwarden/pull/3505) - [@​quexten](https://togithub.com/quexten) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/3578](https://togithub.com/dani-garcia/vaultwarden/pull/3578) - [@​DenuxPlays](https://togithub.com/DenuxPlays) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/3620](https://togithub.com/dani-garcia/vaultwarden/pull/3620) - [@​fashberg](https://togithub.com/fashberg) made their first contribution in [https://github.com/dani-garcia/vaultwarden/pull/3623](https://togithub.com/dani-garcia/vaultwarden/pull/3623) **Full Changelog**: dani-garcia/vaultwarden@1.28.1...1.29.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/arthurgeek/vaultwarden-fly-template). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41LjMiLCJ1cGRhdGVkSW5WZXIiOiIzNi41LjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my understanding, rust never inlines static variables meaning that these variables are separately statically allocated and wasting space.
Even if there's not codegen diff, separately defining these static variables is (imo) code smell.