-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run mobile push requests in background #3579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't thought of it, and didn't figured out, thanks for this catch also
Wouldn't it even be better to run those push functions in the background? Now it spawns multiple threads per user, which could become an issue. But if you put this around the function that calls this function it would probably speed up more. |
Or, make this push functions allow to receive a |
Closing this PR and combining the changes including both of your suggestions in #3578. |
Okay, not sure why but GitHub seems to have closed my PR on force-push. Reopening with this comment. |
I think the reset to main was wrong actually. |
this is the wrong PR |
The last 4 days everyone looked at PR #3578 |
8472104
to
e460643
Compare
Whoops.... my bad. |
Another partial fix for #3577.
Combining this with PR #3578, this should solve #3577.
Mobile push requests are currently run blocking within the HTTP Put for updating a cipher request. In the Bitwarden UI this just shows as if updating the entry takes up to multiple seconds. This request moves the actual HTTP request to the Bitwarden Push servers into a tokio task. This way, sending the notifications does not block the request to update a cipher.