Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement server side default URI matching #3748

Closed

Conversation

matlink
Copy link
Contributor

@matlink matlink commented Aug 3, 2023

See item 4 of #432

Watch #432 (comment) for a little different workflow

@BlackDex
Copy link
Collaborator

This still doesn't resolve the issue @dani-garcia mentioned in #432 (comment)

If you override this, and someone edit's that cipher, it will store the overridden value, and from that point on, it will not be the server side default anymore. If then at a later point you want to change the server-side default, all those previous values will never be updated to the new setting configured on the server side.

I think this will only cause confusion or maybe even issues.
Also, this also breaks the client side default uri match detection which they can configure them self.

@BlackDex
Copy link
Collaborator

From my point of view i still think this will cause more issues then it might solve for some people.
It is also error prone during handling or when you want to change the default to something else.

Going to close this one. If you think it still should be applied, please provide more detailed information or workflows on how this can work and ill recheck,

@BlackDex BlackDex closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants