Add extra linting #4977
Merged
Add extra linting #4977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added extra linting for some code styles. Also added the Rust Edition 2024 lints. Closes dani-garcia#4974 Signed-off-by: BlackDex <black.dex@gmail.com>
|
Hmm, looks like our MSRV doesn't allow those lints yet. |
|
Only available since v1.81.0 it looks like. |
|
i Could comment it out for now and enable it once we are there, and leave the rest as-is. |
dani-garcia
reviewed
Sep 22, 2024
Signed-off-by: BlackDex <black.dex@gmail.com>
dani-garcia
approved these changes
Sep 23, 2024
BlackDex
added a commit
to BlackDex/vaultwarden
that referenced
this pull request
Oct 5, 2024
* Add extra linting Added extra linting for some code styles. Also added the Rust Edition 2024 lints. Closes dani-garcia#4974 Signed-off-by: BlackDex <black.dex@gmail.com> * Adjusted according to comments Signed-off-by: BlackDex <black.dex@gmail.com> --------- Signed-off-by: BlackDex <black.dex@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added extra linting for some code styles.
Also added some of the Rust Edition 2024 lints since our MSRV does not yet support the group lint.
Once we reach 1.81.0 as MSRV we can uncomment it and use that lint.
Closes #4974