IE9: Success callback prematurely called on FileAPI.upload.progress

[Oceanswave]

On browsers that use the FileAPI as a fallback, it appears that if the POST exceeds 10 seconds the .success callback is raised, but the data returned is null

If I use fiddler to look at client/server traffic, I don't see a 204, just my file upload, which completes successfully AFTER the .success() method is called in my controller.

FileAPI Debug:

FileAPI.debug = true
true
FlashAPI.event.mouseenter: [object Object](js -> flash).multiple: false
(js -> flash).accept: *
FlashAPI.event.select: [object Object]
FlashAPI.Form.toData
FlashAPI.XHR._send: fileapi14225600781572 -> 1422560097419812
(js -> flash).upload: [object Object]
FlashAPI.upload.progress
$upload.upload success callback. Status: {"status":204,"config":{"method":"POST","transformResponse":[null],"url":"myService.aspx","file":{"flashId":"fileapi14225600781572","id":"1422560097419812","size":164382,"type":"xlsx","name":"data.xlsx"},"timeout":100000000,"headers":{"Accept":"application/json, text/plain, /"},"data":{"data":[{"key":"file","val":{"flashId":"fileapi14225600781572","id":"1422560097419812","size":164382,"type":"xlsx","name":"data.xlsx"},"name":"data.xlsx"}],"__isFileAPIShim":true},"start":"2015-01-29T19:34:57.429Z","end":"2015-01-29T19:35:07.442Z"},"statusText":"No Content"}
FlashAPI.upload.complete
xhr.end: 200
SCRIPT5007: Unable to get property 'statusText' of undefined or null reference

[Oceanswave]

Looking at the shim -- it appears that there's a timeout after 10 seconds at line 126.

if I remove this, or change the delay to something larger, things work as expected.
if (e.total === e.loaded) {
// fix flash issue that doesn't call complete if there is no response text from the server
var _this = this
setTimeout(function() {
if (!xhr.__completed) {
xhr.getAllResponseHeaders = function(){};
_this.complete(null, {status: 204, statusText: 'No Content'});
}
}, 10000);
}

Can the 10 second delay be surfaced as a configuration setting? There would also seem to be side effects if FileAPI calls the progress callback multiple times.

Thanks,

[danialfarid]

There is a check before that timeout if (e.total === e.loaded) { so it should be only set if the upload is completed and progress is 100%.
So it should only happen if your server doesn't send any response back after 10 seconds of successfully sending all the file content, which since the file is send completely so most probably your response will be success.
I can add that to the FileAPI configuration in case server takes way longer to process the successfully uploaded file and send a response back, but it should be very rare

[Oceanswave]

The service takes some time to process the file, which is why I ran up against this. A configuration setting would be great -- thanks!

[danialfarid]

added the option to FileAPI:
FileAPI.noContentTimeout: 10000

since version 3.0.0

[Oceanswave]

Thank you!

[matgardon]

Sorry to ask, but this doesn't seem to work for me (following the readme : FileAPI = { ... }), and looking at the offending code in the shim, the 10000 value in setTimeout is still hard coded in the 3.0.0 version of your package.

Did I miss something ?

[Oceanswave]

Yeah, I don't think the angular-file-upload release package got properly updated for 3.0.0 -- none of the version numbers have been updated in the files... The demos folder does contain a newer version but outside of that I'm not sure where the 3.0.0 code went.

Some checkin bombed or some grunt task failed methinks.

See #536

[matgardon]

Yup, thanks for the update ! Well for now I hard coded another value and it works.

[danialfarid]

It was a grunt issue, the name in package.json is now ng-file-upload since angular-file-upload name was already taken in both npm and bower registry so the module is registered there with that name.
In the angular dependencies you can use both names.