Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove $ prefixes from name #565

Closed
demisx opened this issue Feb 14, 2015 · 1 comment
Closed

Remove $ prefixes from name #565

demisx opened this issue Feb 14, 2015 · 1 comment

Comments

@demisx
Copy link

demisx commented Feb 14, 2015

$ prefix is reserved for core angular services. Can you please remove them from your own services to follow Angular best practices? For example, it confuses developers thinking that $upload is a service provided by Angular. Thank you.
danialfarid pushed a commit that referenced this issue Apr 23, 2015
Fixed #518, #689, #351, #350, #606, #565, #538 #678
29295b4
@danialfarid
Copy link
Owner

Fixed in version 4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danialfarid @demisx