Added touchend for touch devices instead of click, and fix FastClick issue on Chrome for ios #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylorcode
changed the title
|
You may want to rebase this |
|
+1, @taylorcode can you rebase this? |
|
Fixed in version 3.3.0 I had to do manual change since the files had changed quiet a bit since you submitted pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the 300ms delay for mobile devices, and fixes an issue with FastClick for chrome on iOS. On Chrome for iOS, if FastClick is being used, the click event will not fire. I ran a build (noticed that other contributors were not) because I wasn't sure if this was done automatically.