Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js to v18 #705

Merged
merged 4 commits into from
Feb 14, 2023
Merged

Update Node.js to v18 #705

merged 4 commits into from
Feb 14, 2023

Conversation

daniel-ac-martin
Copy link
Owner

Completes the update to Node.js v18.

@github-actions github-actions bot temporarily deployed to commit February 14, 2023 20:50 Inactive
@cypress
Copy link

cypress bot commented Feb 14, 2023

Passing run #3053 ↗︎

0 1 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

apps: Default to IPv6 in Docker image
Project: NotGovUK Commit: 9d05bf2fca
Status: Passed Duration: 12:10 💡
Started: Feb 14, 2023 10:07 PM Ended: Feb 14, 2023 10:19 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@daniel-ac-martin
Copy link
Owner Author

1: starting server using command "npm run start:test"
and when url "[ 'http-get://localhost:8080/readiness' ]" is responding with HTTP status code NaN

Looks like this will require an update to Cypress (#681) first.

@daniel-ac-martin
Copy link
Owner Author

Actually, just start-server-and-test (#704)...

@github-actions github-actions bot temporarily deployed to commit February 14, 2023 21:10 Inactive
@daniel-ac-martin
Copy link
Owner Author

daniel-ac-martin commented Feb 14, 2023

Error: Timed out waiting for: http-get://localhost:8080/readiness

Seems like there is still some problem with Node.js v18 and start-server-and-test.

@daniel-ac-martin
Copy link
Owner Author

Related: jeffbski/wait-on#133 (comment)

@github-actions github-actions bot temporarily deployed to commit February 14, 2023 22:06 Inactive
@github-actions github-actions bot temporarily deployed to commit February 14, 2023 22:31 Inactive
@daniel-ac-martin daniel-ac-martin merged commit 9cc0754 into master Feb 14, 2023
@daniel-ac-martin daniel-ac-martin deleted the update-node-to-v18 branch February 14, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant