Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin does not support webapp resource files #1

Closed
daniel-beck opened this issue Nov 12, 2018 · 5 comments · Fixed by jenkinsci/stapler#156
Closed

Plugin does not support webapp resource files #1

daniel-beck opened this issue Nov 12, 2018 · 5 comments · Fixed by jenkinsci/stapler#156

Comments

@daniel-beck
Copy link
Owner

Per comments in jenkinsci/localization-zh-cn-plugin#31, this plugin does not currently support help files. The presence of HTML help files for zh_CN resulted in this looking like it'd "just" work, when in fact it does not.

@daniel-beck
Copy link
Owner Author

daniel-beck commented Nov 12, 2018

Mostly handled by 492bb16 for Descriptor#doHelp.

Still open:

  • war/src/main/webapp/ resources (some freestyle job help files)
  • Plugin resource files via Plugin#doDynamic

@daniel-beck daniel-beck changed the title Plugin does not support help files Plugin does not support webapp resource files Nov 12, 2018
@daniel-beck
Copy link
Owner Author

FWIW, neither the currently released localization-zh-cn plugin, nor this one support localizing war/src/main/webapp/ resources, like e.g. http://localhost:8080/help/project-config/custom-workspace.html

So at least this isn't worse than what currently exists.

@daniel-beck
Copy link
Owner Author

daniel-beck commented Nov 12, 2018

TBH, resources like these probably should just be deprecated.

@daniel-beck
Copy link
Owner Author

A number of core help files from webapp cannot easily be migrated to Descriptor#doHelp:

  • scm-browsers does not have a fixed field name to bind to.
  • run-config has no descriptor.
  • LogRecorder also has no descriptor.

The following are known to be migratable:

  • view-config, into View and ListView

@daniel-beck
Copy link
Owner Author

Resolved by a5b4e4f downstream of jenkinsci/stapler#156

daniel-beck added a commit that referenced this issue May 7, 2019
Restore support for localized resources for Descriptor#doHelp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant