Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added custom_mathjax_url option #201

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

dr-br
Copy link
Contributor

@dr-br dr-br commented May 10, 2024

Added the option to define a custom mathjax URL.
Not sure if all the modifications are really necessary in the code, please check!
It also works with the privacy plugin of mkdocs-material.

Off topic: I'm not able to run the demo, some templates are missing in this repo. If I install mkdocs-jupyter via Pypi, the required template files are present.

@danielfrg
Copy link
Owner

This lgtm.

could we do a small change to not create a new Exporter and instead do it with a variable, something like:

default_mathjax_url = "https://cdnjs.cloudflare.com/ajax/libs/mathjax/2.7.7/latest.js?config=TeX-AMS_CHTML-full,Safe"
mathjax_url = custom or default_mathjax_url

@danielfrg
Copy link
Owner

Maybe even make the default of custom_mathjax_url to be "https://cdnjs.cloudflare.com/ajax/libs/mathjax/2.7.7/latest.js?config=TeX-AMS_CHTML-full,Safe"

@danielfrg danielfrg merged commit 6867505 into danielfrg:main Jul 2, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants