Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only copy source files if they are converted by the plugin #222

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

tobiasah
Copy link
Contributor

@tobiasah tobiasah commented Oct 8, 2024

This PR fixes the following issue(s):

Instead of blindly copying all source files, including plain markdown files, only copy files converted by the plugin. This prevents all plain markdown files from being copied into the build output.

I also replaced the print statements with logging statements. Otherwise, the print can easily mess up automated scripts.

This commit adapts the plugin to use a logger instead of print to
integrate better into the mkdocs workflow.
This commit prevents all files from the source directory from beeing
copied to the output. Instead only the source files touched by the module
are copied.
@tobiasah
Copy link
Contributor Author

tobiasah commented Oct 8, 2024

I was unsure which version to use in the Changelog. Once I know, I will happily add my changes to it.

@danielfrg
Copy link
Owner

Thank you!

I havent been doing the best keeping the changelog. The next entry should be 0.25.1

@tobiasah
Copy link
Contributor Author

tobiasah commented Oct 8, 2024

Thank you!

I havent been doing the best keeping the changelog. The next entry should be 0.25.1

Thanks a lot for the fast response. I updated the changelog.

I also upgraded the GitHub action upload-artifact to the latest version to fix the CI. However, I am unsure what to do about deploy-cf-pages. You commented out the if constraint, but I guess it only should run on the main branch, right?

@danielfrg
Copy link
Owner

That one fails for PRs, i never figured out the reason for that, so tahts ok

@tobiasah
Copy link
Contributor Author

tobiasah commented Oct 8, 2024

That one fails for PRs, I never figured out the reason for that, so that's ok

Ok, no worries. Let me know if you are happy with the changes so I can fixup the commits before merging.

@tobiasah
Copy link
Contributor Author

@danielfrg Is ther anything I can do to help you review this PR?

@danielfrg
Copy link
Owner

No, lgtm. Merging.

@danielfrg danielfrg merged commit 177536a into danielfrg:main Oct 14, 2024
7 of 8 checks passed
@danielfrg
Copy link
Owner

I'll try to release this later today.

Copy link

Preview deployment

Name Link
Deploy Preview Url https://4a570b03.mkdocs-jupyter-danielfrg-com.pages.dev
Latest deploy log https://github.com/danielfrg/mkdocs-jupyter/actions/runs/11329469936
Latest commit 177536a
Environment production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants