Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cibuildwheel to build and test wheels #805

Merged
merged 5 commits into from
Dec 31, 2022

Conversation

zariiii9003
Copy link
Contributor

This is just a suggestion, feel free to close it.

It looks like a huge change, but i had to move asammdf into src. Otherwise pytest would try to test the repository code instead of the built and installed wheels. This would fail because there is no cutil binary in the repository. With the asammdf folder hidden in src, it works fine.
The git history of all the moved files should remain untouched.

I see that you had the same issue and just put usedevelop = true into the tox.ini file. But that is not really a solution for the problem, because it does not test the source distribution.

@danielhrisca
Copy link
Owner

Thanks for the PR @zariiii9003. I'm not experienced with all this CI stuff.

Can you have a look on why this tests are failing? I can't tell why it happens.

https://github.com/danielhrisca/asammdf/actions/runs/3804656101/jobs/6472027912

@danielhrisca
Copy link
Owner

Never mind I think it was just some failed test

@zariiii9003
Copy link
Contributor Author

Yes, two windows test are failing, but they are failing locally, too:

  =========================== short test summary info ===========================
  FAILED D:\a\asammdf\asammdf\test\test_mdf.py::TestMDF::test_cut - OSError: [Errno 22] Invalid argument: 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpcgeuvxwa\\tmp0.mf4'
  FAILED D:\a\asammdf\asammdf\test\test_mdf.py::TestMDF::test_cut_demo - OSError: [Errno 22] Invalid argument: 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpcgeuvxwa\\tmp1.mf4'
  ================== 2 failed, 52 passed, 1 warning in 14.83s ===================

@danielhrisca
Copy link
Owner

I've fixed the tests. Can you resolve the new conflicts?

@zariiii9003
Copy link
Contributor Author

There's a sphinx warning D:\a\asammdf\asammdf\.tox\doc\lib\site-packages\asammdf\blocks\mdf_v4.py:docstring of asammdf.blocks.mdf_v4.MDF4.get_invalidation_bits:1: WARNING: more than one target found for cross-reference 'Channel': asammdf.blocks.v2_v3_blocks.Channel, asammdf.blocks.v4_blocks.Channel. Otherwise it should be fine now

@danielhrisca
Copy link
Owner

I think you should run black and isort again.

@danielhrisca danielhrisca marked this pull request as ready for review December 31, 2022 05:47
@danielhrisca danielhrisca merged commit 65e751e into danielhrisca:development Dec 31, 2022
@danielhrisca
Copy link
Owner

Thank you Artur!

@zariiii9003 zariiii9003 deleted the cibuildwheel branch January 1, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants