Review issues 1

danielkec · Oct 5, 2023 · 57476cb · 57476cb
1 parent 406d597
commit 57476cb
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 13 deletions.
diff --git a/http/http2/src/main/java/io/helidon/http/http2/Http2ConnectionWriter.java b/http/http2/src/main/java/io/helidon/http/http2/Http2ConnectionWriter.java
@@ -190,10 +190,8 @@ private void lockedWrite(Http2FrameData frame) {
     private void lock() {
         try {
             streamLock.lockInterruptibly();
-        } catch (RuntimeException e) {
-            throw e;
-        } catch (Exception e) {
-            throw new RuntimeException(e);
+        } catch (InterruptedException e) {
+            throw new IllegalStateException("Interrupted", e);
         }
     }
 

diff --git a/webserver/http2/src/main/java/io/helidon/webserver/http2/Http2ServerStream.java b/webserver/http2/src/main/java/io/helidon/webserver/http2/Http2ServerStream.java
@@ -117,15 +117,15 @@ class Http2ServerStream implements Runnable, Http2Stream {
      * @param connectionFlowControl connection flow control
      */
     Http2ServerStream(ConnectionContext ctx,
-                             Http2ConcurrentConnectionStreams streams,
-                             HttpRouting routing,
-                             Http2Config http2Config,
-                             List<Http2SubProtocolSelector> subProviders,
-                             int streamId,
-                             Http2Settings serverSettings,
-                             Http2Settings clientSettings,
-                             Http2StreamWriter writer,
-                             ConnectionFlowControl connectionFlowControl) {
+                      Http2ConcurrentConnectionStreams streams,
+                      HttpRouting routing,
+                      Http2Config http2Config,
+                      List<Http2SubProtocolSelector> subProviders,
+                      int streamId,
+                      Http2Settings serverSettings,
+                      Http2Settings clientSettings,
+                      Http2StreamWriter writer,
+                      ConnectionFlowControl connectionFlowControl) {
         this.ctx = ctx;
         this.streams = streams;
         this.routing = routing;