Fix number of workers #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-wall
reviewed
Dec 24, 2021
echernous
force-pushed
the
fix/topic-metadata-workers
branch
3 times, most recently
from
220155b
to
ab8b959
Compare
Signed-off-by: Kate Chernousova <eachernous@gmail.com>
echernous
force-pushed
the
fix/topic-metadata-workers
branch
from
ab8b959
to
b373e46
Compare
|
LGTM, thanks @echernous @k-wall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Fixes the following issue - when there is only 1 topic returned in
client.RefreshMetadata()response, kafka-exporter will be stuck in waiting for thegetTopicMetricsfunction which never gets triggered.Signed-off-by: Kate Chernousova eachernous@gmail.com