Adds metrics: kafka_consumergroup_current_offset_sum and kafka_consumergroup_lag_sum #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds summed metrics for
kafka_consumergroup_current_offsetandkafka_consumergroup_lag.Motivation: When running at scale with high counts of consumer groups and very large partition counts, per-partition metrics can force scaling up prometheus (to potentially undesirable size). Having a summary allows for scraping full detail where desired, but scraping only the sum as a bellwether where that detail isn't necessary.
Note - this doesn't currently add
-1with no offset (like the per-partition metric).Testing: Validated against kafka locally with multiple topics, consumergroups, partition sizes.
Note: this includes #69 since otherwise
masteris broken.