false is not overriden by true if preserve_unmergeables #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianpeiris
reviewed
Dec 25, 2016
| hash_src = {'something' => true} | ||
| hash_dst = {'something' => false} | ||
| DeepMerge::deep_merge!(hash_src, hash_dst, {:preserve_unmergeables => true}) | ||
| assert_equal({'something' => false}, hash_dst) |
There was a problem hiding this comment.
Isn't this test incorrect? If you merge {'something' => true} into {'something' => false}, I would expect the result to be {'something' => true}
There was a problem hiding this comment.
Maybe I'm just confused by the expected behavior of this library. Are you suggesting that boolean values should be considered "unmergeable"?
magynhard
pushed a commit
to magynhard/yaml_extend
that referenced
this pull request
May 27, 2018
The deep_merge gem lacks on a issue, reported here: danielsdeleo/deep_merge#23 danielsdeleo/deep_merge#28 As yaml_extend uses this gem to merge, here is a workaround to solve this issue. It will be full forward compatible, if the original deep_merge solves its issue, due we don't patch deep_merge directly in any way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#23