Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configurable timeout delay #25

Merged
merged 4 commits into from
Feb 21, 2018
Merged

Conversation

emericklaw
Copy link
Contributor

I have never experienced issues with duplicate button presses being detected by my buttons so have always run with a very low delay. I am currently running with 0 seconds with no issues and can press different buttons in quick succession and they all trigger.

@danimtb
Copy link
Owner

danimtb commented Jan 17, 2018

Thanks for the contribution!
I think I saw you message in the Hassio forum but I couldnt answer you.

Anyway, I think it is nice to let users choose whatever delay suits theis setup, as this would be very dependant on things suchs the router, the latency of their LAN and even the amount of devices connected to it.

I would just change the merge branch to develop and see if I we can release a new version soon.

@danimtb danimtb changed the base branch from master to devel January 17, 2018 15:09
@emericklaw
Copy link
Contributor Author

emericklaw commented Jan 17, 2018

Ah, it was not me on the forums but I did also see that there are at least two other forks where people have manually changed the timeout to a lower value for their own use.

My Home Assistant install is currently pointing to my repo so no immediate need to release a new version.

@mattlward
Copy link

Does this mean that this is going to happen in the next release? I did ask about it on the homeassistant forum.

Thanks

@danimtb danimtb added this to the 0.3.0 milestone Feb 21, 2018
@danimtb
Copy link
Owner

danimtb commented Feb 21, 2018

Merging this to develop! Thank you @emericklaw again for the contribution! 😄

@danimtb danimtb merged commit 34ed511 into danimtb:devel Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants