Add a search bar #106
Merged
Add a search bar #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the search behaviour will be attached to an action associated with the text view, in order to avoid repeating the same work I'll just create a common component called CarteroCodeView and use it instead of GtkSourceView. Features of CarteroCodeView: * Automatic dark theme when dark mode. * Automatic unidirectional binding to accept the current settings.
After this commit, the search bar can be used in the raw payload pane. However, the buttons only print to stdout information about what button or action you made, still pending to connect to a real search system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention is to add a search bar component that can be plugged into the different text editors (payload pane, export pane, response pane...). When the user presses Ctrl-F, this triggers a search request which may cause the bar to be presented. Then, the search bar can be used to start a search in the associated text view.
Closes #80