Request body panel #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirod
force-pushed
the
request-body-panel
branch
2 times, most recently
from
de74a13 to
22a2b2b
Compare
There are two GObject classes now: BasePayloadPane is the top level abstract class and RawPayloadPane is the implementation. BasePayloadPane defines a property called `payload`. Each implementation shall define its own getter and setter to allow other widgets to take or set the contents of the pane, but each implementation is free to do so on its own way. The RawPayloadPane just takes and sets the SourceView buffer contents, but other implementations may parse the byte array differently.
The tabs will extract the proper payload pane that is visible and use the polymorphic methods to get the payload for that specific pane. A combo box will let the user set the format, and that will cause a different pane to be presented.
danirod
force-pushed
the
request-body-panel
branch
from
22a2b2b to
96548ba
Compare
So that I can detect when the file is dirty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt at #14.
It changes the body tab contents with a more complex widget that has a encoding selection. By default it is set to None, but there are multiple selections:
name=John&surname=Doe).There is now a polymorphic class tree with different widgets that implement the same trait, allowing the tab to just call
payload()to get the payload set by the user, no matter the kind of body that is being used. This will be used in the future for collections as well.