Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppImage support #93

Merged
merged 7 commits into from
Nov 22, 2024
Merged

AppImage support #93

merged 7 commits into from
Nov 22, 2024

Conversation

danirod
Copy link
Owner

@danirod danirod commented Nov 21, 2024

This PR adds a script that builds the AppImage for Cartero.

To use the script, use it as follows:

# To build in default mode:
build-aux/appimage-build.sh stable

# To build in development mode:
build-aux/appimage-build.sh devel

Additionally, this commit adds a debug GitHub Action that will run the script using Ubuntu 24.04, which is the minimum version of Ubuntu that provides the required version of libgtk-4-dev and libadwaita-1-dev.

The generated AppImages will require at least glibc 2.38, since they are built by an Ubuntu 24.04 runner. Therefore, Debian 12, you are probably out of the equation at the moment until someone figures out how to compile in Debian 12 or Ubuntu 22.04 using a newer version of libgtk-4-dev and libadwaita-1-dev than the one provided by the system.

The appimage.yaml action is not meant to be merged. Once it works, each job has to be integrated into the nightly.yaml and stable.yaml action.

🙅 QA / Stoppers:

  • KDE: Cartero icon is rendering with black background in the taskbar.
  • All platforms: icons are failing, in general. Maybe I need to vendor the entire Adwaita icon theme, just like I do on Windows and macOS.
  • Fedora 41: it seems that the output response when making an HTTP response is not coloured, maybe the GtkSourceView datafiles have to be vendored as well.

@danirod danirod self-assigned this Nov 21, 2024
@danirod danirod linked an issue Nov 21, 2024 that may be closed by this pull request
@danirod danirod force-pushed the appimage branch 3 times, most recently from 3872fa3 to 1183d15 Compare November 21, 2024 22:36
Because apparently linuxdeploy will not pack the gdk-pixbuf
SVG loader if the library is not installed.
@danirod danirod merged commit e76f663 into trunk Nov 22, 2024
2 checks passed
@danirod danirod added the Pending backport The pull request needs to be backported to older versions label Nov 22, 2024
@danirod danirod deleted the appimage branch December 12, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending backport The pull request needs to be backported to older versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppImage
1 participant