Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncplayer doesn't pass loglevel to direct mode #1981

Closed
dankamongmen opened this issue Jul 24, 2021 · 2 comments
Closed

ncplayer doesn't pass loglevel to direct mode #1981

dankamongmen opened this issue Jul 24, 2021 · 2 comments
Assignees
@dankamongmen
Labels
enhancement New feature or request
Milestone
2.4.0

Comments

@dankamongmen
Copy link
Owner

I'm pretty sure that e.g. -l8 isn't being passed into ncdirect_init() by ncplayer. All the capabilities are there in direct mode, we just need to be taking the loglevel out of the rendered mode options and plug it into the direct mode ones when -k is used.
@dankamongmen dankamongmen added the enhancement New feature or request label Jul 24, 2021
@dankamongmen dankamongmen added this to the 3.0.0 milestone Jul 24, 2021
@dankamongmen dankamongmen self-assigned this Jul 24, 2021
@dankamongmen
Copy link
Owner Author

hrmmm, ncplayer uses the c++ wrappers; i'm unsure we can jimmy this through the C++ constructor, let's see...

@dankamongmen
Copy link
Owner Author

got it, excellent.

dankamongmen added a commit that referenced this issue Jul 24, 2021
@dankamongmen
[ncpp] Direct constructor: accept flags #1981
31b2085
dankamongmen added a commit that referenced this issue Jul 24, 2021
@dankamongmen
ncplayer: pass loglevel through to direct mode #1981
b67c6b8
@dankamongmen dankamongmen modified the milestones: 3.0.0, 2.4.0 Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dankamongmen dankamongmen

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
1 participant
@dankamongmen