handle symlinks in ncls

[dankamongmen]

in ncls, we have the following:

// handle a single inode of arbitrary type                                                                                              
int handle_inode(std::filesystem::path& dir, const char* p, const struct stat* st, const lsContext& ctx){                               
  (void)st; // FIXME handle symlink (dereflinks)                                                                                        
  (void)ctx; // FIXME handle symlink (dereflinks)                                                                                       
  pthread_mutex_lock(&mtx);                                                                                                             
  work.emplace(job{dir, p});                                                                                                            
  pthread_mutex_unlock(&mtx);                                                                                                           
  pthread_cond_signal(&cond);                                                                                                           
  return 0;                                                                                                                             
}

so yeah, we should resolve those FIXMEs, heh.

[dankamongmen]

probably want to add an -a, too, idk

[dankamongmen]

symlinks seem to be handled just fine as it is?

[dankamongmen]

ahhhh, we're using fstatat() without AT_SYMLINK_NOFOLLOW, so it's resolving links for us. only on MINGW do we use regular ol' fstat(). sooooooo we want AT_SYMLINK_NOFOLLOW unless -L is provided, and we want to handle symlink resolution ourselves. and on the windows path we want lstat() when -L is provided. and i think that's all we need.

[dankamongmen]

alright, got this resolved!