Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sixels aren't being counted in bitmap stats #2507

Closed
dankamongmen opened this issue Dec 27, 2021 · 2 comments
Closed

sixels aren't being counted in bitmap stats #2507

dankamongmen opened this issue Dec 27, 2021 · 2 comments
Assignees
@dankamongmen
Labels
bug Something isn't working
Milestone
3.1.0

Comments

@dankamongmen
Copy link
Owner

I posted a comment on #1740 just now, and looking at the screenshot therein, realized that it claimed 0 bitmap emissions -- this despite it being notcurses-info, and very clearly emitting one.

In kitty, we do correctly count the bitmap:

2021-12-26-213439_884x664_scrot
@dankamongmen dankamongmen added the bug Something isn't working label Dec 27, 2021
@dankamongmen dankamongmen added this to the 3.1.0 milestone Dec 27, 2021
@dankamongmen dankamongmen self-assigned this Dec 27, 2021
@dankamongmen
Copy link
Owner Author

pretty simple, obvious fix. good spot!

2021-12-26-213439_884x664_scrot

@dankamongmen
Copy link
Owner Author

2021-12-26-213626_881x664_scrot

yay

dankamongmen added a commit that referenced this issue Dec 27, 2021
@dankamongmen
[stats] account for bitmap emission in rasterize_sprixels (sixel case) …
94944ab 
…#2507
@dankamongmen dankamongmen changed the title sixels are being counted into bitmap stats sixels aren't being counted in bitmap stats Dec 27, 2021
@dankamongmen dankamongmen mentioned this issue Dec 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dankamongmen dankamongmen

Labels
bug Something isn't working
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
1 participant
@dankamongmen