Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refrain from DECSDM emission unless it's known to be necessary #2587

Closed
dankamongmen opened this issue Jan 30, 2022 · 1 comment · Fixed by #2589
Closed

refrain from DECSDM emission unless it's known to be necessary #2587

dankamongmen opened this issue Jan 30, 2022 · 1 comment · Fixed by #2589
Assignees
@dankamongmen
Labels
bitmaps bitmapped graphics (sixel, kitty, mmap) documentation Improvements or additions to documentation enhancement New feature or request
Milestone
3.1.0

Comments

@dankamongmen
Copy link
Owner

@klamonte brings up a good point in the latter comments of #2204. "most" terminals we can't positively identify are set to scroll sixels by default, and simply omitting DECSDM might be a better strategy than guessing whether they implement it one way or the other. i think she's probably correct.

only emit DECSDM on a positive terminal identification with known semantics, but always do so on such a temrinal, in case it has been placed into the undesirable mode.
@dankamongmen dankamongmen added documentation Improvements or additions to documentation enhancement New feature or request bitmaps bitmapped graphics (sixel, kitty, mmap) labels Jan 30, 2022
@dankamongmen dankamongmen added this to the 3.1.0 milestone Jan 30, 2022
@dankamongmen dankamongmen self-assigned this Jan 30, 2022
@dankamongmen
Copy link
Owner Author

ok, 30 helens agree that this is how we ought proceed.

dankamongmen added a commit that referenced this issue Jan 30, 2022
@dankamongmen
send no DECSDM to unknown terminals #2587
32774c3
@dankamongmen dankamongmen mentioned this issue Jan 30, 2022
Merged
dankamongmen added a commit that referenced this issue Jan 30, 2022
@dankamongmen
send no DECSDM to unknown terminals #2587
779386a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dankamongmen dankamongmen

Labels
bitmaps bitmapped graphics (sixel, kitty, mmap) documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

send no DECSDM to unknown terminals #2587 dankamongmen/notcurses
1 participant
@dankamongmen