Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use move functionality for Kitty graphics #1803

Merged
merged 5 commits into from
Jun 20, 2021
Merged

Conversation

dankamongmen
Copy link
Owner

@dankamongmen dankamongmen commented Jun 20, 2021

Change kitty_wipe() to only set SPRIXEL_INVALIDATED when in SPRIXEL_QUIESCENT, allowing us to use more moves. Introduce sprite_move(), pipe it through to new function kitty_move(). When we can move, it's a drastic reduction in both emitted bytes and flicker over our previous solution of delete+redraw. Closes #1395.

@dankamongmen dankamongmen added the NOMERGE not ready for merge label Jun 20, 2021
@dankamongmen
Copy link
Owner Author

Two problems with this:

  • if we move the plane before we raster it the first time, it's never visible (see box)
  • we're not properly wiping cells in intro

@dankamongmen
Copy link
Owner Author

yeah, if we move the move_ships() to the bottom of the loop in box, they're visible. but this ought work either way.

@dankamongmen dankamongmen removed the NOMERGE not ready for merge label Jun 20, 2021
@dankamongmen
Copy link
Owner Author

ok. we are executing pure moves when possible now, but we have to redraw when we wipe or rebuild, so that locks out most of the wins in intro. on the other hand, box does get cut by about half its output, so that's nice.

the next step is to not require full invalidations, by using the animation protocol to wipe and rebuild.

@dankamongmen dankamongmen merged commit 75bbdc2 into master Jun 20, 2021
@dankamongmen dankamongmen deleted the dankamongmen/kitty-move branch June 20, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve use of kitty pixel graphics protocol
1 participant