Fixing ecospat plots and disabling ranger tests #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was an easy one - we used to have a cast of the rasters to SpatRasters, but now they're SpatRasters to begin with so I just had to cut those bits out.
ranger tests keep failing on Github but not on CRAN - disabling those tests to see if we can get clean GitHub results on other functions
Our do.call rbind magic stopped working, turns out with terra all you need to do is call vect() on a list and it does the trick quite handily!
We were sort of trying to have our cake and eat it too - accepting both rasters and terra SpatRasters, and that was screwing a lot of things up. Now I'm just going to require the new data types and set combined types to NA with a warning if we don't get them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if we can get clean results from our GitHub actions now