Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Command+Click doesn't open a new tab on MacOS #2784

Closed
1 task done
eshack94 opened this issue May 19, 2024 · 3 comments
Closed
1 task done

[Bug]: Command+Click doesn't open a new tab on MacOS #2784

eshack94 opened this issue May 19, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@eshack94
Copy link
Contributor

eshack94 commented May 19, 2024

What happened?

NOTE: This is a very low priority bug report, non-urgent.

Expectation:

  • Librechat on MacOS (regardless of browser) opens links in a new tab if they're clicked while holding the "command" key.

Outcome:

  • Librechat on MacOS does not open a new tab when links are clicked while holding "command" key.

Other Info:

  • Others have said that "ctrl + click" within Windows works as-expected, but have not personally verified. This would indicate that it's an issue with the metaKey (command key) being detected and maybe some conditionals need updating (unsure though, might be something else).

Steps to Reproduce

  1. Be on MacOS.
  2. Make sure LibreChat is running.
  3. Open any web browser.
  4. Log into local LibreChat instance.
  5. Click any clickable link while holding down "command" (meta key).

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

Relevant log output

N/A

Screenshots

N/A

Code of Conduct

  • I agree to follow this project's Code of Conduct
@eshack94 eshack94 added the bug Something isn't working label May 19, 2024
@eshack94
Copy link
Contributor Author

I'm testing a proposed fix, if it works I'll open a PR and link to this bug report.

@eshack94
Copy link
Contributor Author

Opened a PR which fixes this: #2786

@danny-avila
Copy link
Owner

thanks lgtm, wouldn't have been able to test on mac myself 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants