👨🔧 fix: recognize command+click on macos #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where the "command+click" was not being recognized on MacOS. The desired behavior was working fine on Windows using "ctrl+click", but the MacOS equivalent was broken. This was preventing new tabs from opening while holding "command" (meta key) on MacOS and clicking. I verified this change fixes the issue by building locally and testing.
|
This addresses #2784. |
1 task
danny-avila
approved these changes
May 19, 2024
techwithanirudh
pushed a commit
to techwithanirudh/LibreChat-dev
that referenced
this pull request
May 20, 2024
Fixes an issue where the "command+click" was not being recognized on MacOS. The desired behavior was working fine on Windows using "ctrl+click", but the MacOS equivalent was broken. This was preventing new tabs from opening while holding "command" (meta key) on MacOS and clicking. I verified this change fixes the issue by building locally and testing.
danny-avila
pushed a commit
that referenced
this pull request
Aug 5, 2024
Fixes an issue where the "command+click" was not being recognized on MacOS. The desired behavior was working fine on Windows using "ctrl+click", but the MacOS equivalent was broken. This was preventing new tabs from opening while holding "command" (meta key) on MacOS and clicking. I verified this change fixes the issue by building locally and testing.
kenshinsamue
pushed a commit
to intelequia/LibreChat
that referenced
this pull request
Sep 17, 2024
Fixes an issue where the "command+click" was not being recognized on MacOS. The desired behavior was working fine on Windows using "ctrl+click", but the MacOS equivalent was broken. This was preventing new tabs from opening while holding "command" (meta key) on MacOS and clicking. I verified this change fixes the issue by building locally and testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where "command+click" combination was not being recognized on MacOS. The desired behavior was working fine on Windows using "ctrl+click", but the MacOS equivalent was broken.
This was preventing new tabs from opening while holding "command" (meta key) on MacOS and clicking.
Change Type
Testing
I verified this change fixes the issue by building locally and testing.
After making changes locally, I re-built the docker images locally, ran the app, and verified the issue is fixed.
Test Configuration:
Docker Compose, after making changes and rebuilding (without cache) locally.
Checklist
Please delete any irrelevant options.