Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cancel button in the delete modal window has no persistent, visible focus. #3829

Closed
derekjackson-das opened this issue Aug 28, 2024 · 0 comments
Closed

cancel button in the delete modal window has no persistent, visible focus. #3829

derekjackson-das opened this issue Aug 28, 2024 · 0 comments
Assignees
@Tanvez
Labels
a11y Accessibility

Comments

@derekjackson-das
Copy link
Collaborator

Issue Description:
The cancel button in the modal window for deleting a chat thread lacks a persistent visible focus, making it difficult for users navigating via keyboard to identify when the button is focused. This issue affects the accessibility of the interface, as users may not be aware of which element is currently selected.

WCAG Criteria:
2.4.7 Focus Visible - AA

Screenshot or Screen Recording:

Screenshot Recording

Screenshot 2024-08-28 at 4 34 28 PM

Note:
The focus state on the button currently has a transparent outline. To ensure visibility, the outline needs to be changed to a solid color.
@derekjackson-das derekjackson-das added the a11y Accessibility label Aug 28, 2024
Tanvez added a commit to Harvard-University-iCommons/LibreChat that referenced this issue Sep 3, 2024
@Tanvez
fix focus for cancel button in convo delete modal window danny-avila#…
083b9d7 
…3829
@Tanvez Tanvez mentioned this issue Sep 4, 2024
Merged
12 tasks
danny-avila pushed a commit that referenced this issue Sep 5, 2024
@Tanvez
👐 a11y: Misc. Improvements (#3910)
b9197f9 
* fix focus for cancel button in convo delete modal window #3829

* add aria-hidden and aria-label to X and Check svg/button respectively and updated OGDialogClose focus color

* update rename, newchat, newchat icon, ConvoOptions icon
illgitthat pushed a commit to illgitthat/LibreChat that referenced this issue Sep 8, 2024
@pull @Tanvez
@zjjxwhh @hide361 @marlonka @itzraiss @itzraisu
[pull] main from danny-avila:main (#1)
3db1aeb 
* 👐 a11y: Misc. Improvements (danny-avila#3910)

* fix focus for cancel button in convo delete modal window danny-avila#3829

* add aria-hidden and aria-label to X and Check svg/button respectively and updated OGDialogClose focus color

* update rename, newchat, newchat icon, ConvoOptions icon

* 🌍 i18n: Updated Chinese Translation (danny-avila#3871)

* 🌍 : Updated Chinese Translation

* 🌍 : Updated Chinese Translation

* 🌍 i18n: Update Japanese translation (danny-avila#3877)

* 🌍 i18n: Improved German language translations (danny-avila#3924)

* 🌍 i18n: Improved Portuguese language translations (danny-avila#3947)

Co-authored-by: RaiSantos <itzraisu@gmail.com>

---------

Co-authored-by: Vesna Tan <tanvezi@gmail.com>
Co-authored-by: Hervey <zjjxwhh@163.com>
Co-authored-by: hide361 <180006476+hide361@users.noreply.github.com>
Co-authored-by: Marlon <153027575+marlonka@users.noreply.github.com>
Co-authored-by: Raí Santos <140329135+itzraiss@users.noreply.github.com>
Co-authored-by: RaiSantos <itzraisu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tanvez Tanvez

Labels
a11y Accessibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Tanvez @derekjackson-das @danny-avila