👤 fix: Use user?.username if user?.name is undefined
#2511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilsubyeega
changed the title
user?.username if user?.name is undefined on profile sectionuser?.username if user?.name is undefined
|
Thanks! I’m not sure why I used the name 🤔 |
danny-avila
requested changes
Apr 24, 2024
danny-avila
changed the title
user?.username if user?.name is undefineduser?.username if user?.name is undefined
danny-avila
approved these changes
Apr 24, 2024
danny-avila
pushed a commit
that referenced
this pull request
Aug 5, 2024
* Use `user?.username` if `user?.name` is undefined * Add useLocalize hook to Icon component
kenshinsamue
pushed a commit
to intelequia/LibreChat
that referenced
this pull request
Sep 17, 2024
…#2511) * Use `user?.username` if `user?.name` is undefined * Add useLocalize hook to Icon component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a patch to show names to users who don't have a
user?.namebut have auser?.username. I encountered this issue using Github SSO for my account.This issue might need a patch in the future to fill
usernametonameproperty in server-side SSO integrationChange Type
Testing
I've tested messages and navlinks, but icon (i have no idea how to create it now).
Checklist