Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔒 feat: add option to disable TLS for LDAP authentication #3247

Merged
merged 8 commits into from
Jul 27, 2024
Merged

🔒 feat: add option to disable TLS for LDAP authentication #3247

merged 8 commits into from
Jul 27, 2024

Conversation

ravi-katiyar
Copy link
Contributor

@ravi-katiyar ravi-katiyar commented Jul 2, 2024 •
edited
Loading

#3243

Summary

This PR allows to disable tls when LDAP authentication is used.

Change Type

  • New feature
  • This change requires a documentation update

Checklist

@ravi-katiyar ravi-katiyar marked this pull request as draft July 2, 2024 06:04
@ravi-katiyar ravi-katiyar force-pushed the feat/ldap-tls-config branch 2 times, most recently from d7970fa to 5097b1f Compare July 2, 2024 10:36
berry-13
berry-13 requested changes Jul 4, 2024
View reviewed changes
api/strategies/ldapStrategy.js Outdated Show resolved Hide resolved
@ravi-katiyar ravi-katiyar marked this pull request as ready for review July 4, 2024 11:17
@berry-13 berry-13 changed the title Update ldapStrategy.js 🔒 feat: add option to disable TLS for LDAP authentication Jul 4, 2024
@ravi-katiyar
Copy link
Contributor Author

@danny-avila please let me know if anything is pending at my end for this.

@ravi-katiyar
Copy link
Contributor Author

@berry-13 please let me if there's anything pending on this , I would like to get this merged.

@danny-avila
Copy link
Owner

@ravi-katiyar can you add relevent documentation to

https://www.librechat.ai/docs/configuration/authentication/ldap ?

https://github.com/LibreChat-AI/librechat.ai/blob/main/pages/docs/configuration/authentication/ldap.mdx ?

Since you area also adding an .env variable, you should update this too: https://github.com/LibreChat-AI/librechat.ai/blob/main/pages/docs/configuration/dotenv.mdx

@ravi-katiyar ravi-katiyar mentioned this pull request Jul 11, 2024
Merged
@ravi-katiyar
Copy link
Contributor Author

@ravi-katiyar can you add relevent documentation to

https://www.librechat.ai/docs/configuration/authentication/ldap ?

https://github.com/LibreChat-AI/librechat.ai/blob/main/pages/docs/configuration/authentication/ldap.mdx ?

Since you area also adding an .env variable, you should update this too: https://github.com/LibreChat-AI/librechat.ai/blob/main/pages/docs/configuration/dotenv.mdx

@danny-avila , Thanks for pointing that out. PR submitted to update the docs LibreChat-AI/librechat.ai#89

@danny-avila danny-avila merged commit 18fd8f1 into danny-avila:main Jul 27, 2024
1 check passed
danny-avila added a commit that referenced this pull request Aug 5, 2024
@ravi-katiyar @danny-avila
🔒 feat: add option to disable TLS for LDAP authentication (#3247)
c2925cb 
* feat: add ldap tls config

* Update ldapStrategy.js

* LDAP_TLS_REJECT_UNAUTHORIZED optional

---------

Co-authored-by: Danny Avila <danacordially@gmail.com>
Co-authored-by: Danny Avila <danny@librechat.ai>
danny-avila added a commit that referenced this pull request Aug 17, 2024
@ravi-katiyar @danny-avila
🔒 feat: add option to disable TLS for LDAP authentication (#3247)
6a54ce5 
* feat: add ldap tls config

* Update ldapStrategy.js

* LDAP_TLS_REJECT_UNAUTHORIZED optional

---------

Co-authored-by: Danny Avila <danacordially@gmail.com>
Co-authored-by: Danny Avila <danny@librechat.ai>
kenshinsamue pushed a commit to intelequia/LibreChat that referenced this pull request Sep 17, 2024
@ravi-katiyar @danny-avila
🔒 feat: add option to disable TLS for LDAP authentication (danny-avil…
fdcf370 
…a#3247)

* feat: add ldap tls config

* Update ldapStrategy.js

* LDAP_TLS_REJECT_UNAUTHORIZED optional

---------

Co-authored-by: Danny Avila <danacordially@gmail.com>
Co-authored-by: Danny Avila <danny@librechat.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berry-13 berry-13 berry-13 approved these changes

@danny-avila danny-avila danny-avila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ravi-katiyar @danny-avila @berry-13