Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐋 ci: Dockerfile.multi rewrite, maintain package integrity #3772

Merged
merged 3 commits into from
Aug 24, 2024

Conversation

danny-avila
Copy link
Owner

@danny-avila danny-avila commented Aug 24, 2024

  • Removed the prod-stage build in Dockerfile.multi, opting to share dist files between services instead.
  • Implemented a new base stage in Dockerfile.multi to centralize common setup steps.
  • Restructured the build stages to optimize caching and reduce redundant operations.
  • Added a named volume 'client-dist' in deploy-compose.yml to share client dist files between services.
  • Updated the NGINX configuration in deploy-compose.yml to use the shared client dist files.
  • Removed the 'prepare' script from package.json as it's no longer needed in the new build process.
  • Made minor adjustments to the server code, improving readability and organization.

While this may affect users employing usage of deploy-compose.yml, the changes are necessary as prior to these changes, the project's package versions are not maintained across builds.

@danny-avila danny-avila merged commit 88d8706 into main Aug 24, 2024
2 checks passed
@danny-avila danny-avila deleted the chore/rewrite-dockerfile.multi branch August 24, 2024 19:00
kenshinsamue pushed a commit to intelequia/LibreChat that referenced this pull request Sep 17, 2024
…la#3772)

* chore: touch server

* chore: dockerfile.multi first pass

* refactor: remove prod-stage build, share dist files instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant