-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colors dissapear and text is messed up on kakoune master #27
Comments
Interesting, do you know which changes to kakoune are causing this? |
I have bissected and it seems this change was introduced in commit 954373d3cfa9d168f7949f12cb7b2e730d18de99 This commit is not really documented. It is named |
Thanks for bisecting! Maybe the easymotion code is doing something sloppy around line endings that now get catched with this new commit. |
Maybe related: #29 |
I am also experiencing this. |
I am putting a $25 Bitcoin bounty on this (enough for a pizza basically). It should also resolve #29 . |
Looked into this, only the red foreground is missing, if you change EasyMotionForeground to set a background it will still show. This includes formatting such as underlines or italics. This doesn't solve it but can be used to increase contrast. I've also messed around with the new replace-ranges and the reason that lines are missing is that the return character is replaced on the above line. This most likely has to do with the added functionality to allow someone to implement code folding. I think fixing this on the plugin side is honestly impractical. |
If the task is more difficult or time consuming than expected I will raise the bounty in increments of $25 USD. |
I made a minimal reproducer. Have the following buffer (27 times "a\n") and execute
You'll see that the last two lines are joined |
My proposed solution after some investigation would be to also get the selection contents to the python script. Getting the selections to the python script is not trivial, since currently all the variables are sent to the python script in one string, delimited by |
I'm revoking the bounty; it seems there are some deep issues with the plugin, and after learning some kakoune script myself, I'm not sure I see a proficient way to achieve this functionality. (Also, no one has declared to be working on it.) |
I'm using workaround (order is important):
|
Fixes danr#27 The strategy is to select the newlines in addition to the targets so that we can keep track of line lengths. Then if a range would have replaced a newline, the replaced string is clamped to the last character of the line.
Fixes danr#27 The strategy is to select the newlines in addition to the targets so that we can keep track of line lengths. Then if a range would have replaced a newline, the replaced string is clamped to the last character of the line.
Using this plugin in Kakoune master works but the preview is a bit messed up (see the right part of the picture)
The text was updated successfully, but these errors were encountered: