Merge pull request #21 from dantleech/nofragments

remove fragments
dantleech · Jan 27, 2019 · 26a65a0 · 26a65a0
2 parents 92f8ecb + eba2544
commit 26a65a0
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## [Unreleased]
+
+- Unconditionally remove URL fragments.
+
 ## [0.2.1] - 2019-01-26
 
 - Use correct autoload path when included as a dependency

diff --git a/lib/Model/Url.php b/lib/Model/Url.php
@@ -82,6 +82,11 @@ public function resolveUrl($link): self
             $link = $link->withPort($this->uri->getPort());
         }
 
+        if ($link->getFragment()) {
+            // unconditionally remove fragments
+            $link = $link->withFragment('');
+        }
+
         return new self($link, $this, $this->distance + 1);
     }
 

diff --git a/tests/Unit/Model/UrlTest.php b/tests/Unit/Model/UrlTest.php
@@ -98,6 +98,12 @@ public function provideResolve()
             'templates.html',
             'https://example.com:1234/templates.html'
         ];
+
+        yield 'ignores fragments' => [
+            'https://example.com',
+            '#foobar',
+            'https://example.com'
+        ];
     }
 
     public function testIsHttp()