Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fink to User Agent #46

Closed
gitressa opened this issue Feb 19, 2019 · 2 comments
Closed

Add fink to User Agent #46

gitressa opened this issue Feb 19, 2019 · 2 comments

Comments

@gitressa
Copy link
Contributor

It would be great if fink was added to the User Agent in DefaultClient.php

Currently
const DEFAULT_USER_AGENT = 'Mozilla/5.0 (compatible; Artax)';

Something like this?
const DEFAULT_USER_AGENT = 'Mozilla/5.0 (compatible; fink; Artax)';
dantleech added a commit that referenced this issue Feb 19, 2019
@dantleech
Allow custom headers, fixes #46
e6692ad
@dantleech
Copy link
Owner

Added in #47 which sets the includes FinkPHP in the user agent, but also allows setting of custom headers via. --header="X-MyHeader: 1234abcd.

dantleech added a commit that referenced this issue Feb 19, 2019
@dantleech
Merge pull request #47 from dantleech/gh-46-custom-headers
c5ba4c8 
Allow custom headers, fixes #46
@gitressa
Copy link
Contributor Author

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dantleech @gitressa