Fix drawAxes to allow one of two Y axes to be drawn #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed the broken tests from the first push by refactoring some code. |
mirabilos
added a commit
that referenced
this pull request
Jan 25, 2023
|
I have merged this without the test timeout increase, as it was not needed. Thank you! |
|
This unfortunately caused a regression: https://dygraphs.com/tests/unboxed-spark.html disables drawing of the lines, and this did not work any more correctly. fixed by 046bdec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. This fix is for a bug I noticed that prevented the drawAxes function to properly show only one Y axis when there is data for both. I added a test to cover Y1 drawn, but not Y2 and one for Y2 drawn, but not Y1.
Separately, the docs state the default is that Y2 is not drawn, but the code has all axes drawn by default. I am not sure which is correct so I did not change either.
Thanks for the great work!