Implement coroutine features and guardThis feature (#177) #191
+366
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danvratil
force-pushed
the
work/coro-features
branch
2 times, most recently
from
78d1619
to
701316b
Compare
danvratil
force-pushed
the
work/coro-features
branch
from
701316b
to
167df2c
Compare
danvratil
force-pushed
the
work/coro-features
branch
from
167df2c
to
7567602
Compare
danvratil
force-pushed
the
work/coro-features
branch
from
4dda880
to
9e3dddc
Compare
danvratil
force-pushed
the
work/coro-features
branch
from
9e3dddc
to
2dd5a6c
Compare
Since it's likely going to be unused in most coroutines, make it use only sizeof void* rather than sizeof CoroutineFeatures bytes.
danvratil
force-pushed
the
work/coro-features
branch
from
a565bc9
to
3bef597
Compare
danvratil
force-pushed
the
work/coro-features
branch
from
92d76d7
to
c821d06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By calling
co_await QCoro::thisCoro()user can obtain CoroutineFeatures object specific to the current coroutine, and through it they can control behavior of the coroutine.The one feature implemented so far is "guardThis", which monitors the lifetime of a given QObject-derived object. If the object is destroyed while the coroutine is suspended, when the time comes to resume it, it is destroyed instead. This is mostly useful to watch lifetime of
this, so that when a member coroutine function is suspended and the object is deleted in the meantime, it will prevent the coroutine from continuing with a danglingthispointer when resumed.