Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-12859 test: use pool and container labels (pass 3) #13210

Merged
merged 25 commits into from
Sep 16, 2024
Merged

DAOS-12859 test: use pool and container labels (pass 3) #13210

merged 25 commits into from
Sep 16, 2024

Conversation

daltonbohning
Copy link
Contributor

Test-tag: ContainerQueryAttributeTest ManagementServiceResilience test_bashcmd ParallelIo NvmePoolCapacity DestroyTests ListPoolsTest QueryAttributeTest RbldBasic RbldBasic RbldPoolDestroyWithIO RbldReadArrayTest RbldWithIO ObjectMetadata performance,-manual container,pr DaosVolBigIO DaosVol MacsioTest TestWithScrubberBasic TestWithScrubberFault TestWithScrubberTargetEviction dfuse datamover test_container_redundancy_factor_oclass_enforcement RbldContRfTest osa RbldCascadingFailures RbldDeleteObjects RbldReadArrayTest

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this Oct 19, 2023
daosbuild1
daosbuild1 reviewed Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@github-actions
Copy link

Bug-tracker data:
Ticket title is 'CI tests should be using Pool and Container labels and not uuids'
Status is 'In Progress'
Labels: 'test_fix,test_q2,triaged'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-12859

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Oct 19, 2023
daosbuild1
daosbuild1 reviewed Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13210/2/execution/node/750/log

daosbuild1
daosbuild1 reviewed Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13210/3/execution/node/749/log

daosbuild1
daosbuild1 reviewed Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13210/4/execution/node/749/log

daosbuild1
daosbuild1 reviewed Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13210/5/testReport/

daosbuild1
daosbuild1 reviewed Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13210/6/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13210/6/testReport/

@daltonbohning daltonbohning marked this pull request as ready for review October 24, 2023 22:39
@daltonbohning daltonbohning requested a review from a team as a code owner October 24, 2023 22:39
@daltonbohning
Copy link
Contributor Author

Failures in https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-13210/6/testReport/
are known https://daosio.atlassian.net/browse/DAOS-14517

shimizukko
shimizukko previously approved these changes Oct 24, 2023
View reviewed changes
@daltonbohning
Merge remote-tracking branch 'origin/master' into dbohning/daos-12859…
2f9ec5c 
…-pass3

Test-tag: ContRfEnforce ManagementServiceResilience MacsioTest ParallelIo  NvmePoolCapacity DestroyTests ListPoolsTest QueryAttributeTest RbldBasic RbldCascadingFailures RbldNoCapacity RbldPoolDestroyWithIO RbldReadArrayTest RbldWithIO scrubber ObjectMetadata DmvrDstCreate DmvrObjSmallTest DmvrPreserveProps RbldDeleteObjects DaosVolBigIO DaosVol osa
Skip-unit-tests: true
Skip-fault-injection-test: true
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13210/37/execution/node/781/log

@daltonbohning
Merge remote-tracking branch 'origin/master' into dbohning/daos-12859…
f004eda 
…-pass3

Test-tag: ContRfEnforce ManagementServiceResilience MacsioTest ParallelIo  NvmePoolCapacity DestroyTests ListPoolsTest QueryAttributeTest RbldBasic RbldCascadingFailures RbldNoCapacity RbldPoolDestroyWithIO RbldReadArrayTest RbldWithIO scrubber ObjectMetadata DmvrDstCreate DmvrObjSmallTest DmvrPreserveProps RbldDeleteObjects DaosVolBigIO DaosVol osa
Skip-unit-tests: true
Skip-fault-injection-test: true
@daltonbohning
Merge remote-tracking branch 'origin/master' into dbohning/daos-12859…
74fb2fc 
…-pass3

Test-tag: ContRfEnforce ManagementServiceResilience MacsioTest ParallelIo  NvmePoolCapacity DestroyTests ListPoolsTest QueryAttributeTest RbldBasic RbldCascadingFailures RbldNoCapacity RbldPoolDestroyWithIO RbldReadArrayTest RbldWithIO scrubber ObjectMetadata DmvrDstCreate DmvrObjSmallTest DmvrPreserveProps RbldDeleteObjects DaosVolBigIO DaosVol osa
Skip-unit-tests: true
Skip-fault-injection-test: true
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13210/39/execution/node/781/log

@daltonbohning
Merge remote-tracking branch 'origin/master' into dbohning/daos-12859…
d26f932 
…-pass3

Test-tag: ContRfEnforce ManagementServiceResilience MacsioTest ParallelIo  NvmePoolCapacity DestroyTests ListPoolsTest QueryAttributeTest RbldBasic RbldCascadingFailures RbldNoCapacity RbldPoolDestroyWithIO RbldReadArrayTest RbldWithIO scrubber ObjectMetadata DmvrDstCreate DmvrObjSmallTest DmvrPreserveProps RbldDeleteObjects DaosVolBigIO DaosVol osa
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13210/40/execution/node/806/log

@daltonbohning
Merge remote-tracking branch 'origin/master' into dbohning/daos-12859…
6deaf05 
…-pass3

Test-tag: pr ContRfEnforce DestroyTests ListPoolsTest MacsioTest ManagementServiceResilience NvmePoolCapacity ObjectMetadata ParallelIo QueryAttributeTest RbldCascadingFailures RbldNoCapacity RbldPoolDestroyWithIO RbldReadArrayTest RbldWithIO TestScrubberEvictWithAggregation TestScrubberEvictWithRebuild TestScrubberEvictWithSnapshot TestWithScrubberBasic TestWithScrubberFault TestWithScrubberFreq TestWithScrubberTargetEviction scrubber DmvrDstCreate DmvrObjSmallTest DmvrPreserveProps RbldDeleteObjects DaosVolBigIO DaosVol osa
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13210/41/execution/node/784/log

@daltonbohning
Merge remote-tracking branch 'origin/master' into dbohning/daos-12859…
b2532cf 
…-pass3

Features: ContRfEnforce DestroyTests ListPoolsTest MacsioTest ManagementServiceResilience NvmePoolCapacity ObjectMetadata ParallelIo QueryAttributeTest RbldCascadingFailures RbldNoCapacity RbldPoolDestroyWithIO RbldReadArrayTest RbldWithIO TestScrubberEvictWithAggregation TestScrubberEvictWithRebuild TestScrubberEvictWithSnapshot TestWithScrubberBasic TestWithScrubberFault TestWithScrubberFreq TestWithScrubberTargetEviction scrubber DmvrDstCreate DmvrObjSmallTest DmvrPreserveProps RbldDeleteObjects DaosVolBigIO DaosVol osa
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@github-actions github-actions bot removed the priority Ticket has high priority (automatically managed) label Jul 22, 2024
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13210/42/execution/node/798/log

@daltonbohning
Merge remote-tracking branch 'origin/master' into dbohning/daos-12859…
00dca2a 
…-pass3

Features: ContRfEnforce DestroyTests ListPoolsTest MacsioTest ManagementServiceResilience NvmePoolCapacity ObjectMetadata ParallelIo QueryAttributeTest RbldCascadingFailures RbldNoCapacity RbldPoolDestroyWithIO RbldReadArrayTest RbldWithIO TestScrubberEvictWithAggregation TestScrubberEvictWithRebuild TestScrubberEvictWithSnapshot TestWithScrubberBasic TestWithScrubberFault TestWithScrubberFreq TestWithScrubberTargetEviction scrubber DmvrDstCreate DmvrObjSmallTest DmvrPreserveProps RbldDeleteObjects DaosVolBigIO DaosVol osa
Skip-unit-tests: true
Skip-fault-injection-test: true
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13210/43/execution/node/1099/log

@daltonbohning
Merge remote-tracking branch 'origin/master' into dbohning/daos-12859…
4ccd890 
…-pass3
@daltonbohning
fix macsio_test
f0e1d01 
Features: ContRfEnforce DestroyTests ListPoolsTest MacsioTest ManagementServiceResilience NvmePoolCapacity ObjectMetadata ParallelIo QueryAttributeTest RbldCascadingFailures RbldNoCapacity RbldPoolDestroyWithIO RbldReadArrayTest RbldWithIO TestScrubberEvictWithAggregation TestScrubberEvictWithRebuild TestScrubberEvictWithSnapshot TestWithScrubberBasic TestWithScrubberFault TestWithScrubberFreq TestWithScrubberTargetEviction scrubber DmvrDstCreate DmvrObjSmallTest DmvrPreserveProps RbldDeleteObjects DaosVolBigIO DaosVol osa
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13210/44/execution/node/1010/log

@daltonbohning
Copy link
Contributor Author

Single test failure in https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-13210/44/tests/
must be unrelated because the only changes that affect server/metadata.py are print statements.

@daltonbohning daltonbohning requested review from shimizukko and rpadma2 and removed request for rpadma2 September 11, 2024 21:10
@daltonbohning daltonbohning requested a review from a team September 16, 2024 15:20
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Sep 16, 2024
@phender
Copy link
Contributor

phender commented Sep 16, 2024

Single test failure in https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-13210/44/tests/ must be unrelated because the only changes that affect server/metadata.py are print statements.

The failure was a test timeout while destroying containers.

@phender phender merged commit 98ddb2f into master Sep 16, 2024
47 of 49 checks passed
@phender phender deleted the dbohning/daos-12859-pass3 branch September 16, 2024 16:50
daltonbohning added a commit that referenced this pull request Oct 4, 2024
@daltonbohning
DAOS-12859 test: use pool and container labels (pass 3) (#13210)
3852280 
Features: ContRfEnforce DestroyTests ListPoolsTest MacsioTest ManagementServiceResilience NvmePoolCapacity ObjectMetadata ParallelIo QueryAttributeTest RbldCascadingFailures RbldNoCapacity RbldPoolDestroyWithIO RbldReadArrayTest RbldWithIO TestScrubberEvictWithAggregation TestScrubberEvictWithRebuild TestScrubberEvictWithSnapshot TestWithScrubberBasic TestWithScrubberFault TestWithScrubberFreq TestWithScrubberTargetEviction scrubber DmvrDstCreate DmvrObjSmallTest DmvrPreserveProps RbldDeleteObjects DaosVolBigIO DaosVol osa
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning added a commit that referenced this pull request Oct 8, 2024
@daltonbohning
DAOS-12859 test: use pool and container labels (pass 3) (#13210)
f3c9c39 
Features: ContRfEnforce DestroyTests ListPoolsTest MacsioTest ManagementServiceResilience NvmePoolCapacity ObjectMetadata ParallelIo QueryAttributeTest RbldCascadingFailures RbldNoCapacity RbldPoolDestroyWithIO RbldReadArrayTest RbldWithIO TestScrubberEvictWithAggregation TestScrubberEvictWithRebuild TestScrubberEvictWithSnapshot TestWithScrubberBasic TestWithScrubberFault TestWithScrubberFreq TestWithScrubberTargetEviction scrubber DmvrDstCreate DmvrObjSmallTest DmvrPreserveProps RbldDeleteObjects DaosVolBigIO DaosVol osa
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@shimizukko shimizukko shimizukko approved these changes

@phender phender phender approved these changes

@dinghwah dinghwah Awaiting requested review from dinghwah

@rpadma2 rpadma2 Awaiting requested review from rpadma2

Assignees

@daltonbohning daltonbohning

Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daltonbohning @daosbuild1 @phender @shimizukko