Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14535 pool: start/stop ds_pool_child individually (#13347) #14431

Merged
merged 2 commits into from
May 24, 2024
Merged

DAOS-14535 pool: start/stop ds_pool_child individually (#13347) #14431

merged 2 commits into from
May 24, 2024

Conversation

jolivier23
Copy link
Contributor

Reorganize ds_pool_child start/stop code to make it able to be started/stopped individually:

  • Introduced four states for ds_pool_child: NEW, STARTING, STARTED and STOPPING.
  • ds_pool_child is added/removed to/from cache through the collective call of pool_child_add/delete_one(), now the cache doesn't hold the ds_pool_child reference anymore.
  • Introduced ds_pool_child_start/stop() for callers to start/stop ds_pool_child individually, ds_pool_child_state() to query the state of ds_pool_child.
  • Removed ds_pool_child_get();

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@NiuYawei @jolivier23
DAOS-14535 pool: start/stop ds_pool_child individually (#13347)
f2c5070 
Reorganize ds_pool_child start/stop code to make it able to be
started/stopped individually:

- Introduced four states for ds_pool_child: NEW, STARTING, STARTED
  and STOPPING.
- ds_pool_child is added/removed to/from cache through the collective
  call of pool_child_add/delete_one(), now the cache doesn't hold the
  ds_pool_child reference anymore.
- Introduced ds_pool_child_start/stop() for callers to start/stop
  ds_pool_child individually, ds_pool_child_state() to query the state
  of ds_pool_child.
- Removed ds_pool_child_get();

Signed-off-by: Niu Yawei <yawei.niu@intel.com>
@github-actions GitHub Actions
Copy link

Bug-tracker data:
Ticket title is 'Handle WAL/Meta SSD faulty'
Status is 'Resolved'
Labels: 'md_on_ssd'
https://daosio.atlassian.net/browse/DAOS-14535

daosbuild1
daosbuild1 reviewed May 24, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@jolivier23 jolivier23 requested a review from NiuYawei May 24, 2024 03:25
NiuYawei
NiuYawei reviewed May 24, 2024
View reviewed changes
src/include/daos_srv/pool.h Outdated
struct ds_pool_svc_op_val {
int ov_rc;
char ov_resvd[60];
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these two extra changes for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were one of the sections of the merge conflict. I will remove them.

@jolivier23
Bad merge
d05502c 
Required-githooks: true

Change-Id: I3ebda5dc2f9914d74f42954b5c294afd8e96d398
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23 jolivier23 requested a review from NiuYawei May 24, 2024 04:33
daosbuild1
daosbuild1 reviewed May 24, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@jolivier23 jolivier23 merged commit 28d189a into google/2.4 May 24, 2024
32 of 34 checks passed
@jolivier23 jolivier23 deleted the jvolivie/backport_fix branch May 24, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@NiuYawei NiuYawei NiuYawei approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jolivier23 @NiuYawei @daosbuild1