Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-623 build: Update packaging to… (#14513) #14514

Merged
merged 1 commit into from
Jun 5, 2024
Merged

DAOS-623 build: Update packaging to… (#14513) #14514

merged 1 commit into from
Jun 5, 2024

Conversation

brianjmurrell
Copy link
Contributor

Pick up a fix from the packaging repo for getting the HPE repository
signing key from our Artifactory instead of he HPE servers. This
insulates us from mangement issues with their server such as when they
forget to update their certificate.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
    • Unit Testing and Testing were skipped as this PR only affects Ubuntu and building and we don't test on Ubuntu
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@brianjmurrell
DAOS-623 build: Update packaging to… (#14513)
362823e 
Pick up a fix from the packaging repo for getting the HPE repository
signing key from our Artifactory instead of he HPE servers.  This
insulates us from mangement issues with their server such as when they
forget to update their certificate.

Skip-PR-comments: true
Skip-unit-tests: true
Skip-test: true

Required-githooks: true

Signed-off-by: Brian J. Murrell <brian.murrell@intel.com>
@brianjmurrell brianjmurrell self-assigned this Jun 5, 2024
@brianjmurrell brianjmurrell changed the base branch from master to release/2.6 June 5, 2024 17:40
@brianjmurrell brianjmurrell added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Jun 5, 2024
@brianjmurrell brianjmurrell marked this pull request as ready for review June 5, 2024 17:41
@brianjmurrell brianjmurrell requested a review from a team as a code owner June 5, 2024 17:41
@brianjmurrell brianjmurrell requested a review from a team June 5, 2024 18:18
@phender phender merged commit 8deffe2 into release/2.6 Jun 5, 2024
51 of 54 checks passed
@phender phender deleted the bmurrell/use-HPE-key-from-artifactory branch June 5, 2024 18:22
@brianjmurrell brianjmurrell changed the title Bmurrell/use-HPE-key-from-artifactory DAOS-623 build: Update packaging to… (#14513) Jun 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Ticket title is 'Generic ticket for minor code cleanup and improvement'
Status is 'Resolved'
Labels: 'request_for_2.6,request_for_2.6.1'
https://daosio.atlassian.net/browse/DAOS-623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning approved these changes

@JohnMalmberg JohnMalmberg JohnMalmberg approved these changes

@grom72 grom72 Awaiting requested review from grom72

@ryon-jensen ryon-jensen Awaiting requested review from ryon-jensen

Assignees

@brianjmurrell brianjmurrell

Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brianjmurrell @daltonbohning @JohnMalmberg @phender