Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16168 build: Ignore scons version deprecation #14715

Merged
merged 2 commits into from
Jul 8, 2024
Merged

DAOS-16168 build: Ignore scons version deprecation #14715

merged 2 commits into from
Jul 8, 2024

Conversation

jolivier23
Copy link
Contributor

Disable warning for deprecated support for python
version so it doesn't fail the build.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@jolivier23
DAOS-16161 build: Ignore scons version deprecation
eb61939 
Disable warning for deprecated support for python
version so it doesn't fail the build.

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23 jolivier23 requested review from a team as code owners July 8, 2024 18:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

Ticket title is 'Functional on <> / FTEST_dfuse.DaosBuild.<>-./dfuse/daos_build.py:DaosBuild.test_dfuse_daos_build_wt_il'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-16168

daltonbohning
daltonbohning reviewed Jul 8, 2024
View reviewed changes
SConstruct Outdated Show resolved Hide resolved
@jolivier23
fix warning
27d1aa8 
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@jolivier23 jolivier23 changed the title DAOS-16161 build: Ignore scons version deprecation DAOS-16168 build: Ignore scons version deprecation Jul 8, 2024
@mchaarawi mchaarawi merged commit 1bfc198 into master Jul 8, 2024
45 of 47 checks passed
@mchaarawi mchaarawi deleted the jvolivie/ignore_dep branch July 8, 2024 19:04
jolivier23 added a commit that referenced this pull request Jul 8, 2024
@jolivier23
DAOS-16168 build: Ignore scons version deprecation (#14715)
283dc52 
Disable warning for deprecated support for python
version so it doesn't fail the build.

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
jolivier23 added a commit that referenced this pull request Jul 8, 2024
@jolivier23
DAOS-16168 build: Ignore scons version deprecation (#14715)
019aba1 
Disable warning for deprecated support for python
version so it doesn't fail the build.

Required-githooks: true
Skip-test: true

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
jolivier23 added a commit that referenced this pull request Jul 8, 2024
@jolivier23
DAOS-16168 build: Ignore scons version deprecation (#14715)
815d340 
Disable warning for deprecated support for python
version so it doesn't fail the build.

Skip-test: true

Required-githooks: true

Change-Id: I7753b5e32e291fe748cddfe4caea2fc851b15e66
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
jolivier23 added a commit that referenced this pull request Jul 8, 2024
@jolivier23
DAOS-16168 build: Ignore scons version deprecation (#14715)
a7cff71 
Disable warning for deprecated support for python
version so it doesn't fail the build.

Skip-test: true

Required-githooks: true

Change-Id: I7753b5e32e291fe748cddfe4caea2fc851b15e66
Signed-off-by: Jeff Olivier <jeffolivier@google.com>
jolivier23 added a commit that referenced this pull request Jul 8, 2024
@jolivier23
DAOS-16168 build: Ignore scons version deprecation (#14715) (#14718)
d84e9da 
Disable warning for deprecated support for python
version so it doesn't fail the build.

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
jolivier23 added a commit that referenced this pull request Jul 8, 2024
@jolivier23
DAOS-16168 build: Ignore scons version deprecation (#14715) (#14719)
509745d 
Disable warning for deprecated support for python
version so it doesn't fail the build.

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
kccain pushed a commit that referenced this pull request Jul 8, 2024
@jolivier23 @kccain
DAOS-16168 build: Ignore scons version deprecation (#14715)
d56a11d 
cherry-pick of master commit for debug branch purposes

Disable warning for deprecated support for python
version so it doesn't fail the build.

Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-test: true

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
Signed-off-by: Kenneth Cain <kenneth.c.cain@intel.com>
kccain pushed a commit that referenced this pull request Jul 10, 2024
@jolivier23 @kccain
DAOS-16168 build: Ignore scons version deprecation (#14715)
821420e 
Disable warning for deprecated support for python
version so it doesn't fail the build.

Test-tag: test_daos_rebuild_ec
Test-repeat: 20
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
Signed-off-by: Kenneth Cain <kenneth.c.cain@intel.com>
jolivier23 added a commit that referenced this pull request Jul 11, 2024
@jolivier23
DAOS-16168 build: Ignore scons version deprecation (#14715)
45b6a1c 
Disable warning for deprecated support for python
version so it doesn't fail the build.

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
daltonbohning pushed a commit that referenced this pull request Jul 12, 2024
@jolivier23
DAOS-16168 build: Ignore scons version deprecation (#14715) (#14717)
500d59d 
Disable warning for deprecated support for python
version so it doesn't fail the build.

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
@techbasset techbasset mentioned this pull request Jul 16, 2024
Merged
grom72 pushed a commit to grom72/daos that referenced this pull request Jul 25, 2024
@jolivier23 @grom72
DAOS-16168 build: Ignore scons version deprecation (daos-stack#14715)
77ee56f 
Disable warning for deprecated support for python
version so it doesn't fail the build.

Signed-off-by: Jeff Olivier <jeffolivier@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchaarawi mchaarawi mchaarawi approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jolivier23 @mchaarawi @daltonbohning