Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16352 control: Handle cases with static ifaces #14953

Merged
merged 1 commit into from
Aug 21, 2024
Merged

DAOS-16352 control: Handle cases with static ifaces #14953

merged 1 commit into from
Aug 21, 2024

Conversation

kjacque
Copy link
Contributor

@kjacque kjacque commented Aug 17, 2024 •
edited
Loading

Fabric interfaces defined statically in the daos_agent config file are fundamentally different from those detected via hardware scanning. They don't include information derived from the hardware such as their true device class or fabric provider(s).

This patch adds some rigor to what is ignored regarding these manually-defined interfaces.

  • Ignore provider for statically-defined fabric interfaces, as we do not bother detecting it. They are assumed to be compatible with whatever provider the agent is using.
  • Silence confusing "no interfaces requested" error from WaitFabricReady by not calling it if there are no interfaces to check.
  • Remove some defunct logic related to detecting the provider in the multi-provider case. The agent may only use a single provider.

Features: control

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@kjacque
DAOS-16352 control: Handle cases with static ifaces
3b8b1de 
Fabric interfaces defined statically in the daos_agent config
file are fundamentally different from those detected via hardware
scanning. They don't include information derived from the hardware
such as their true device class or fabric provider(s).

This patch adds some rigor to what is ignored regarding these
manually-defined interfaces.

- Ignore provider for statically-defined fabric interfaces, as we
  do not bother detecting it. They are assumed to be compatible with
  whatever provider the agent is using.
- Silence confusing "no interfaces requested" error from
  WaitFabricReady by not calling it if there are no interfaces to
  check.
- Remove some defunct logic related to detecting the provider in
  the multi-provider case. The agent may only use a single provider.

Features: control

Required-githooks: true

Signed-off-by: Kris Jacque <kris.jacque@intel.com>
@kjacque kjacque self-assigned this Aug 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 17, 2024 •
edited
Loading

Ticket title is 'daos_agent crash with static fabric config'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-16352

@kjacque kjacque added the control-plane work on the management infrastructure of the DAOS Control Plane label Aug 17, 2024
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14953/1/execution/node/1594/log

@kjacque
Copy link
Contributor Author

kjacque commented Aug 19, 2024

Test failure is a known issue in master: https://daosio.atlassian.net/issues/DAOS-16334

@kjacque kjacque marked this pull request as ready for review August 19, 2024 15:07
@kjacque kjacque requested review from a team as code owners August 19, 2024 15:07
@kjacque kjacque added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Aug 19, 2024
knard-intel
knard-intel approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@knard-intel knard-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for what I understand.

@kjacque kjacque requested a review from a team August 20, 2024 16:25
@daltonbohning daltonbohning merged commit 6107475 into master Aug 21, 2024
58 of 60 checks passed
@daltonbohning daltonbohning deleted the kjacque/agent-static-fabric-config branch August 21, 2024 17:48
kjacque added a commit that referenced this pull request Aug 22, 2024
@kjacque
DAOS-16352 control: Handle cases with static ifaces (#14953)
cd0f0fd 
Fabric interfaces defined statically in the daos_agent config
file are fundamentally different from those detected via hardware
scanning. They don't include information derived from the hardware
such as their true device class or fabric provider(s).

This patch adds some rigor to what is ignored regarding these
manually-defined interfaces.

- Ignore provider for statically-defined fabric interfaces, as we
  do not bother detecting it. They are assumed to be compatible with
  whatever provider the agent is using.
- Silence confusing "no interfaces requested" error from
  WaitFabricReady by not calling it if there are no interfaces to
  check.
- Remove some defunct logic related to detecting the provider in
  the multi-provider case. The agent may only use a single provider.

Features: control

Required-githooks: true

Signed-off-by: Kris Jacque <kris.jacque@intel.com>
daltonbohning pushed a commit that referenced this pull request Aug 29, 2024
@kjacque
DAOS-16352 control: Handle cases with static ifaces (#14953) (#14991)
ffb4aaa 
Fabric interfaces defined statically in the daos_agent config
file are fundamentally different from those detected via hardware
scanning. They don't include information derived from the hardware
such as their true device class or fabric provider(s).

This patch adds some rigor to what is ignored regarding these
manually-defined interfaces.

- Ignore provider for statically-defined fabric interfaces, as we
  do not bother detecting it. They are assumed to be compatible with
  whatever provider the agent is using.
- Silence confusing "no interfaces requested" error from
  WaitFabricReady by not calling it if there are no interfaces to
  check.
- Remove some defunct logic related to detecting the provider in
  the multi-provider case. The agent may only use a single provider.

Signed-off-by: Kris Jacque <kris.jacque@intel.com>
@jolivier23 jolivier23 mentioned this pull request Sep 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjmac mjmac mjmac approved these changes

@knard-intel knard-intel knard-intel approved these changes

@tanabarr tanabarr Awaiting requested review from tanabarr

Assignees

@kjacque kjacque

Labels
control-plane work on the management infrastructure of the DAOS Control Plane forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kjacque @daosbuild1 @mjmac @knard-intel @daltonbohning