Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16484 test: Support mixed speeds when selecting a default interf… #15080

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

phender
Copy link
Contributor

@phender phender commented Sep 5, 2024

…ace (#15050)

Allow selecting a default interface that is running at a different speed on different hosts. Primarily this is to support selecting the ib0 interface by default when the launch node has a slower ib0 interface than the cluster hosts.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: test_setup test_setup_vm

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

…ace (#15050)

Allow selecting a default interface that is running at a different speed
on different hosts.  Primarily this is to support selecting the ib0
interface by default when the launch node has a slower ib0 interface
than the cluster hosts.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: test_setup test_setup_vm

Signed-off-by: Phil Henderson <phillip.henderson@intel.com>
@phender phender requested review from a team as code owners September 5, 2024 19:00
Copy link

github-actions bot commented Sep 5, 2024

Ticket title is 'Mixed speed ib0 addapters results in eth0 being selected '
Status is 'In Review'
Labels: 'scrubbed_2.8'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16484

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Sep 5, 2024
@phender phender added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Sep 5, 2024
@phender
Copy link
Contributor Author

phender commented Sep 6, 2024

Fix proven in HW Large stage:

2024/09/06 02:46:46 DEBUG             _default_interface: Detecting network devices - D_INTERFACE not set
2024/09/06 02:46:46 DEBUG                     run_remote: Running on wolf-[304,318-325] with a 120 second timeout: grep -l 'up' /sys/class/net/*/operstate | grep -Ev '/(lo|bond)/' | sort
2024/09/06 02:46:47 DEBUG                log_result_data:   wolf-304 (rc=0):
2024/09/06 02:46:47 DEBUG                log_result_data:     /sys/class/net/eth0/operstate
2024/09/06 02:46:47 DEBUG                log_result_data:     /sys/class/net/ib0/operstate
2024/09/06 02:46:47 DEBUG                log_result_data:   wolf-[318-325] (rc=0):
2024/09/06 02:46:47 DEBUG                log_result_data:     /sys/class/net/eth0/operstate
2024/09/06 02:46:47 DEBUG                log_result_data:     /sys/class/net/ib0/operstate
2024/09/06 02:46:47 DEBUG                log_result_data:     /sys/class/net/ib1/operstate
2024/09/06 02:46:47 INFO           get_common_interfaces: Active network interfaces detected:
2024/09/06 02:46:47 INFO           get_common_interfaces:   - eth0     on wolf-[304,318-325] (Common=True)
2024/09/06 02:46:47 INFO           get_common_interfaces:   - ib0      on wolf-[304,318-325] (Common=True)
2024/09/06 02:46:47 INFO           get_common_interfaces:   - ib1      on wolf-[318-325] (Common=False)
2024/09/06 02:46:47 DEBUG                     run_remote: Running on wolf-[304,318-325] with a 120 second timeout: cat /sys/class/net/eth0/speed
2024/09/06 02:46:47 DEBUG                log_result_data:   wolf-[304,318-325] (rc=0): 1000
2024/09/06 02:46:47 DEBUG                     run_remote: Running on wolf-[304,318-325] with a 120 second timeout: cat /sys/class/net/ib0/speed
2024/09/06 02:46:47 DEBUG                log_result_data:   wolf-304 (rc=0): 100000
2024/09/06 02:46:47 DEBUG                log_result_data:   wolf-[318-325] (rc=0): 200000
2024/09/06 02:46:47 INFO           get_fastest_interface: Active network interface speeds on wolf-[304,318-325]:
2024/09/06 02:46:47 INFO           get_fastest_interface:   - eth0     (speed:   1000)
2024/09/06 02:46:47 INFO           get_fastest_interface:   - ib0      (speed: 100000)
2024/09/06 02:46:47 INFO           get_fastest_interface: Available interfaces on wolf-[304,318-325]: {1000: 'eth0', 100000: 'ib0'}
2024/09/06 02:46:47 INFO           get_fastest_interface: Fastest interface detected on wolf-[304,318-325]: ib0

Stopped https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15080/1/ as the HW Medium run wasn't required.

@phender phender merged commit f7d3523 into release/2.6 Sep 6, 2024
43 of 44 checks passed
@phender phender deleted the pahender/DAOS-16484_fix branch September 6, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits priority Ticket has high priority (automatically managed)
Development

Successfully merging this pull request may close these issues.

2 participants