Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16584 test: Support running independent io sys admin steps #15134

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

daltonbohning
Copy link
Contributor

Support running independent io sys admin steps from the yaml.

Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this Sep 16, 2024
Copy link

github-actions bot commented Sep 16, 2024

Ticket title is 'ftest: support running independent io_sys_admin.py steps'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-16584

run_step_storage_system_query: True
run_step_io: True
run_step_snapshot: True
run_test_datamover: True
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run_test_datamover: True
run_step_datamover: True

returned_space = self.get_free_space()[1] - nvme_free_space_before_snap_destroy
counter += 1

if run_test_datamover:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if run_test_datamover:
if run_step_datamover:

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15134/3/execution/node/922/log

Support running independent io sys admin steps from the yaml.

Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning
Copy link
Contributor Author

From the steps.log, all 5 steps are being executed
https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15134/4/artifact/Functional%20Hardware%20Medium/deployment/io_sys_admin.py/steps.log

2024-09-17 18:21:56,813 test             L0471 INFO | ==> Step 4: Verify pool creation time and container set-owner [elapsed since last step: 0.01s]
2024-09-17 18:23:11,398 test             L0471 INFO | ==> Step 5: Verify storage scan and system query [elapsed since last step: 74.59s]
2024-09-17 18:23:17,405 test             L0471 INFO | ==> Step 6: Verifying large dataset IO [elapsed since last step: 6.01s]
2024-09-17 18:25:30,310 test             L0471 INFO | ==> Step 7: Verifying snapshot creation and aggregation [elapsed since last step: 132.90s]
2024-09-17 18:26:37,771 test             L0471 INFO | ==> Step 8: Verifying datamover [elapsed since last step: 67.46s]

@daltonbohning daltonbohning marked this pull request as ready for review September 17, 2024 19:06
@daltonbohning daltonbohning requested review from a team as code owners September 17, 2024 19:06
@daltonbohning daltonbohning changed the title DAOS-623 test: Support running independent io sys admin steps DAOS-16584 test: Support running independent io sys admin steps Sep 17, 2024
Copy link
Contributor

@shimizukko shimizukko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can separate them to five different tests? Anyway, this is much better. Thanks.

@daltonbohning
Copy link
Contributor Author

Maybe we can separate them to five different tests? Anyway, this is much better. Thanks.

Unfortunately some of the steps rely on previous steps for the pool and container to be created. We could just have each step start fresh in a separate test case, but then we can't run all 5 tests in sequential order because avocado doesn't guarantee sorted runs

@daltonbohning daltonbohning requested a review from a team September 17, 2024 22:18
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Sep 17, 2024
@phender
Copy link
Contributor

phender commented Sep 17, 2024

Maybe we can separate them to five different tests? Anyway, this is much better. Thanks.

Unfortunately some of the steps rely on previous steps for the pool and container to be created. We could just have each step start fresh in a separate test case, but then we can't run all 5 tests in sequential order because avocado doesn't guarantee sorted runs

For different test files that's true, but if we defined separate test methods in the same file they would run in order. The problem really is that while we can keep the server and agent up and running across test variants, we currently always destroy the pools and containers.

@daltonbohning
Copy link
Contributor Author

daltonbohning commented Sep 17, 2024

For different test files that's true, but if we defined separate test methods in the same file they would run in order. The problem really is that while we can keep the server and agent up and running across test variants, we currently always destroy the pools and containers.

Methods in the SAME file DO run in order? (just clarifying here - I didn't realize that was the case)

@phender phender merged commit cf25508 into master Sep 17, 2024
47 checks passed
@phender phender deleted the dbohning/daos-623-io-sys-admin branch September 17, 2024 22:31
daltonbohning added a commit that referenced this pull request Sep 17, 2024
Support running independent io sys admin steps from the yaml.

Skip-test: true
Skip-build: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning added a commit that referenced this pull request Sep 17, 2024
Support running independent io sys admin steps from the yaml.

Skip-test: true
Skip-build: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning added a commit that referenced this pull request Sep 24, 2024
Support running independent io sys admin steps from the yaml.

Skip-test: true
Skip-build: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning added a commit that referenced this pull request Oct 4, 2024
Support running independent io sys admin steps from the yaml.

Skip-test: true
Skip-build: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning added a commit that referenced this pull request Oct 4, 2024
Support running independent io sys admin steps from the yaml.

Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning added a commit that referenced this pull request Oct 7, 2024
#15248)

Support running independent io sys admin steps from the yaml.

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
daltonbohning added a commit that referenced this pull request Oct 10, 2024
#15248)

Support running independent io sys admin steps from the yaml.

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

4 participants