Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-14408 common: ensure NDCTL not used for storage class ram #15203

Merged
merged 7 commits into from
Oct 16, 2024

Commits on Oct 10, 2024

  1. DAOS-14408 common: enable NDCTL for DCPM

    This PR prepares DAOS to be used with NDCTL enabled in PMDK, which means:
    - NDCTL must not be used when non-DCPM (simulate PMem) - `storage class: "ram"` is used:
    `PMEMOBJ_CONF=sds.at_create=0` env variable disables NDCTL features in the PMDK
    This change affects all tests run on simulated PMem (e.g. inside VMs).
    Some DOAS utility applications may also require `PMEMOBJ_CONF=sds.at_create=0` to be set.
    
    - The default ULT stack size must be at least 20KiB to avoid stack overuse by PMDK with NDCTL enabled and be aligned with Linux page size.
    `ABT_THREAD_STACKSIZE=20480` env variable is used to increase the default ULT stack size.
    This env variable is set by control/server module just before engine is started.
    Much bigger stack is used for pmempool open/create-related tasks e.g. `tgt_vos_create_one` to avoid stack overusage.
    
    This modification shall not affect md-on-ssd mode as long as `storage class: "ram"` is used for the first tier in the `storage` configuration.
    This change does not require any configuration changes to existing systems.
    
    The new PMDK package with NDCTL enabled (daos-stack/pmdk#38) will land as soon as this PR is merged.
    
    Allow-unstable-test: true
    Priority: 2
    
    Required-githooks: true
    
    Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
    grom72 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    2efa66c View commit details
    Browse the repository at this point in the history
  2. Full validation w/ PMDK w/ NDCTL

    PR-repos: pmdk@PR-38:14
    
    Skip-list: test_dfuse_daos_build_wt_pil4dfs:DAOS-16556
    Priority: 2
    
    Cancel-prev-build: false
    Force tests on various OSes
    Skip-func-test-leap15: false
    Skip-func-test-el9: false
    Skip-test-leap-15.4-rpms: false
    Skip-test-el9-rpms: false
    Allow-unstable-test: true
    
    Required-githooks: true
    
    Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
    grom72 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    c468401 View commit details
    Browse the repository at this point in the history
  3. Full validation w/ PMDK w/ NDCTL (2nd)

    PR-repos: pmdk@PR-38:14
    
    Skip-list: test_dfuse_daos_build_wt_pil4dfs:DAOS-16556
    Priority: 2
    
    Cancel-prev-build: false
    Force tests on various OSes
    Skip-func-test-leap15: false
    Skip-func-test-el9: false
    Skip-test-leap-15.4-rpms: false
    Skip-test-el9-rpms: false
    Allow-unstable-test: true
    
    Required-githooks: true
    
    Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
    grom72 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    4f20d1c View commit details
    Browse the repository at this point in the history
  4. Full validation w/ PMDK w/ NDCTL w/o NLT

    PR-repos: pmdk@PR-38:14
    
    Skip-list: test_dfuse_daos_build_wt_pil4dfs:DAOS-16556
    Priority: 2
    
    Cancel-prev-build: false
    Skip-nlt: true
    Force tests on various OSes
    Skip-func-test-leap15: false
    Skip-func-test-el9: false
    Skip-test-leap-15.4-rpms: false
    Skip-test-el9-rpms: false
    Allow-unstable-test: true
    
    Required-githooks: true
    
    Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
    grom72 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b72401b View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Full validation w/ PMDK w/ NDCTL w/o NLT (replay)

    PR-repos: pmdk@PR-38:14
    
    Skip-list: test_dfuse_daos_build_wt_pil4dfs:DAOS-16556
    Priority: 2
    
    Cancel-prev-build: false
    Skip-nlt: true
    Force tests on various OSes
    Skip-func-test-leap15: false
    Skip-func-test-el9: false
    Skip-test-leap-15.4-rpms: false
    Skip-test-el9-rpms: false
    Allow-unstable-test: true
    
    Required-githooks: true
    
    Signed-off-by: Jan Michalski <jan.michalski@intel.com>
    janekmi committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    8e93405 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. NLT validation only

    PR-repos: pmdk@PR-38:14
    
    Skip-list: test_dfuse_daos_build_wt_pil4dfs:DAOS-16556
    Priority: 2
    
    Cancel-prev-build: false
    Skip-nlt: false
    Skip-unit-test-memcheck: true
    Skip-unit-test: true
    Skip-func-test: true
    
    Required-githooks: true
    
    Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
    grom72 committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    83b2a69 View commit details
    Browse the repository at this point in the history
  2. Fix merge commit.

    Doc-only: true
    
    Required-githooks: true
    
    Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
    grom72 committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    6e7aed1 View commit details
    Browse the repository at this point in the history